tests: move legacy snapcraft tests (CRAFT-728)
Metadata
Current evaluation
Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename.
Resolution: closed resolved
Reason: PR #3609 was approved and merged as a71aeff54, relocating the legacy unit tests to tests/legacy after the package was renamed to snapcraft_legacy.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The legacy snapcraft package was renamed to `snapcraft_legacy`, so move
its unit tests to `tests/legacy`.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3609 moved snapcraft_legacy unit tests from tests/unit to tests/legacy via merge commit a71aeff54, completing the CRAFT-728 test relocation. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3609 moved the renamed snapcraft_legacy unit tests from tests/unit to tests/legacy; merge commit a71aeff54. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes relocating unit tests for the legacy snapcraft package to tests/legacy following its rename to snapcraft_legacy. The request passed static and unit test checks before integration. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3608
(confidence 98%)
Merged as 8cdb15d54, renaming the package to snapcraft_legacy; PR #3609 aligned its tests with that rename.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package. | |
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged as commit 55ad11ccc: a pure test-suite reorganization (788 files, +615/-589) moving test files out of the snapcraft/ package dir into top-level tests/; approved by a maintainer and now reflected in the current tests/unit layout. | |
| #2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere | snapcraft | merged | PR #2295 merged as commit ffbad69ea: unit tests now use SNAPCRAFT_PACKAGE_TYPE instead of legacy SNAPCRAFT_FROM_* env vars, and unused container tests were removed to ease migration to spread. (LP: #1794379) | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #1625 tests: use the snapcraft snap for integration tests | snapcraft | merged | Merged PR #1625 updated integration tests to run the installed Snapcraft snap, better matching the user environment. Resolution: commit eebb070e6. | |
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup. | |
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged in snapcraft-rocks#85, removing six obsolete test lines after upgrading past the stable Snapcraft behavior delivered by canonical/snapcraft#4666. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR #2096 in commit 0e27e147d, replacing integration tests' use of Snapcraft's os_release and repo modules with test-specific helpers; it fixes #1982. | |
| #3608 many: rename snapcraft package to snapcraft_legacy (CRAFT-726) | snapcraft | merged | Merged PR #3608 renamed the existing snapcraft package to snapcraft_legacy, freeing the snapcraft name for a craft-library-based application while leaving its entry point unchanged. | |
| #386 tests: update testing to use craft-test | fetch-service | merged | Merged #386 as commit 323b0e1, replacing direct Spread calls with snapcraft test and updating the test base to core24. |