tests: move legacy snapcraft tests (CRAFT-728)
Metadata
Current evaluation
Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines).
Suggested action: —
No scores available.
Issue body
The legacy snapcraft package was renamed to `snapcraft_legacy`, so move
its unit tests to `tests/legacy`.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes relocating unit tests for the legacy snapcraft package to tests/legacy following its rename to snapcraft_legacy. The request passed static and unit test checks before integration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by cmatsuoka. Moved unit tests for the renamed snapcraft_legacy package to tests/legacy to align with the package rename. Resolves CRAFT-728. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions. | |
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | Merged after reviewer approval and passing CI. The change removes the snapcraft dependency from integration tests to improve test independence, modifying 27 files with 956 additions and 733 deletions. | |
| #3608 many: rename snapcraft package to snapcraft_legacy (CRAFT-726) | snapcraft | merged | Merged after renaming the snapcraft package to snapcraft_legacy to make room for a new craft libraries-based application. Approved, passed CI, and modified 557 files. The application entry point remains unchanged and will be handled separately. | |
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Approved and passing local tests, the changes to move test files out of the snapcraft directory were abandoned after a merge conflict arose. The maintainer closed the request to retry the file relocation later. | |
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged. | |
| #50 test: test the snapcraft actions | craft-actions | merged | Merged adding tests for snapcraft actions, mirroring charmcraft tests. Approved by two reviewers with all CI checks passing. Updates two files with 89 additions and 1 deletion. | |
| #386 tests: update testing to use craft-test | fetch-service | merged | Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines). | |
| #2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere | snapcraft | merged | Merged PR #2295 to replace SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across all tests, removing unused container tests and streamlining the spread testing transition. Approved with no coverage impact. | |
| #1394 tests: document the test suites in the snapcraft repo | snapcraft | merged | Test suite documentation added to snapcraft. Approved by two reviewers, the merge updated two files with 160 additions and 33 deletions to clarify test execution. Reviewer feedback was incorporated prior to merging. | |
| #6204 test: regression tests for .snapcraft.yaml as project file | snapcraft | merged | Merged regression tests for #5083 confirming .snapcraft.yaml detection. The fix was previously applied in PR #5349 via a craft-application 5 refactor. Adds unit, integration, and spread tests covering all supported project file locations. |