environment: get LD_LIBRARY_PATH
Metadata
Current evaluation
Merged PR #3758 via 6e8835dc8, fixing core22 LD_LIBRARY_PATH detection to match core20; follow-up PR #3764 added coverage and removed obsolete libgl1-mesa ld.conf searching.
Resolution: closed resolved
Reason: The pull request was merged as commit 6e8835dc8, delivering the core22 LD_LIBRARY_PATH fix. Follow-up PR #3764 added coverage and removed obsolete libgl1-mesa ld.conf searching.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Properly determine path for LD_LIBRARY_PATH for core22. The behavior should be identical to core20.
This is a hasty PR. I still have a few changes to make, perhaps they can be in a follow up PR if this one needs to get merged ASAP.
Changes to make:
1. More unit tests
2. Some cleanup/refactoring (documentation, comments, types)
(CRAFT-1095)
LP: # [1975498](https://bugs.launchpad.net/snapcraft/+bug/1975498)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3758 via 6e8835dc8, fixing core22 LD_LIBRARY_PATH detection to match core20; follow-up PR #3764 added coverage and removed obsolete libgl1-mesa ld.conf searching. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3758 into main, fixing core22 LD_LIBRARY_PATH resolution to match core20; implementation 6abfa6309, merge 6e8835dc8. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3758 into main, fixing core22 LD_LIBRARY_PATH resolution to match core20; implementation commit 6abfa6309, merge commit 6e8835dc8. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to main. Resolves LD_LIBRARY_PATH resolution for core22 to match core20 behavior. Approved by two reviewers, passed CI, and increased coverage by 0.12%. Follow-up PRs planned for additional tests and refactoring. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Fixes LD_LIBRARY_PATH resolution for core22 to match core20. Increases coverage by 0.12% with 96.22% diff coverage. Resolves CRAFT-1095 and LP #1975498. Follow-up tests and cleanup planned. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3764
(confidence 100%)
Follow-up PR removed obsolete libgl1-mesa ld.conf searching and added LD_LIBRARY_PATH test coverage.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3764 enviroment: deprecate ld.conf.so library path searching for libgl1-mesa | snapcraft | merged | Merged PR #3764 removed obsolete ld.conf.so searching for libgl1-mesa and added LD_LIBRARY_PATH test coverage; merge commit 6ab9c418a. |