← Back to issue list

environment: get LD_LIBRARY_PATH

View original Github issue

Metadata

Project
snapcraft
Number
#3758
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged to main. Resolves LD_LIBRARY_PATH resolution for core22 to match core20 behavior. Approved by two reviewers, passed CI, and increased coverage by 0.12%. Follow-up PRs planned for additional tests and refactoring.

Suggested action: —

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Properly determine path for LD_LIBRARY_PATH for core22. The behavior should be identical to core20. This is a hasty PR. I still have a few changes to make, perhaps they can be in a follow up PR if this one needs to get merged ASAP. Changes to make: 1. More unit tests 2. Some cleanup/refactoring (documentation, comments, types) (CRAFT-1095) LP: # [1975498](https://bugs.launchpad.net/snapcraft/+bug/1975498)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged to main. Resolves LD_LIBRARY_PATH resolution for core22 to match core20 behavior. Approved by two reviewers, passed CI, and increased coverage by 0.12%. Follow-up PRs planned for additional tests and refactoring.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Fixes LD_LIBRARY_PATH resolution for core22 to match core20. Increases coverage by 0.12% with 96.22% diff coverage. Resolves CRAFT-1095 and LP #1975498. Follow-up tests and cleanup planned.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Corrects LD_LIBRARY_PATH resolution for core22 to align with core20. Increased overall coverage by 0.12% with 96.22% diff coverage. Author plans follow-up commits for unit tests and code refactoring.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4669 fix(core24): use correct libc6 path snapcraft merged Merged a fix updating the core24 libc6 linker path to /usr to accommodate usrmerge. Approved by two reviewers, passed CI, and maintained full test coverage on modified lines.
72%