Fix run()'s shell quoting
Metadata
Current evaluation
Superseded by PR #473. The fix replaced $* with "$@" in run() to prevent IFS splitting. Approved for testing but closed without merging in favor of an alternative implementation.
Suggested action: —
No scores available.
Issue body
"$@" is the proper way to expand original positional args; $\* will perform an extra IFS split.
NB: I realize that I'm not following proper contribution rules and that I have other branches to update, but I didn't want to lose this one :-)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #473. The fix replaced $* with "$@" in run() to prevent IFS splitting. Approved for testing but closed without merging in favor of an alternative implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Shell quoting in run() was corrected by replacing $* with $@. The patch was approved for testing but closed without merging, superseded by pull request #473. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by PR #473. Proposed using "$@" instead of "$*" to properly expand positional arguments in run(). Approved for testing but closed without merging. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #473 Fix shell quoting | snapcraft | merged | Merged a fix for shell quoting that replaces $* with "$@" to prevent unintended IFS splitting when expanding positional arguments. Approved by reviewers and applied across four files. |