Fix shell quoting
Metadata
Current evaluation
Merged a fix for shell quoting that replaces $* with "$@" to prevent unintended IFS splitting when expanding positional arguments. Approved by reviewers and applied across four files.
Suggested action: —
No scores available.
Issue body
"$@" is the proper way to expand original positional args; $\* will
perform an extra IFS split.
LP: #1572129
Signed-off-by: Loïc Minier loic.minier@ubuntu.com
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for shell quoting that replaces $* with "$@" to prevent unintended IFS splitting when expanding positional arguments. Approved by reviewers and applied across four files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for shell quoting by replacing $* with "$@" to prevent unintended IFS splitting during positional argument expansion. Approved by maintainers and integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Replaced $* with "$@" to correctly expand positional arguments without unintended IFS splitting. Approved by maintainers and integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #376 Fix run()'s shell quoting | snapcraft | closed | Superseded by PR #473. The fix replaced $* with "$@" in run() to prevent IFS splitting. Approved for testing but closed without merging in favor of an alternative implementation. | |
| #3599 desktop: improve shell substitution logic | snapcraft | merged | Merged to master after passing CI and receiving two approvals. The single-line change improves shell substitution logic to resolve shellcheck error SC2295, with no coverage impact. |