setup assets: ensure hooks when command-chain is present
Metadata
Current evaluation
Merged into main. Fixes hook generation when command-chain is present, resolving extension setup issues. Approved by reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
This is mostly relevant for when using extensions (like the
desktop ones that add a "configure" hook to set up the font
cache).
The original implementation lives in
snapcraft_legacy/internal/meta/_snap_packaging
.py::_SnapPackaging::generate_hook_wrappers
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Fixes hook generation when command-chain is present, resolving extension setup issues. Approved by reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Ensures hooks are properly initialized when command-chain is present, resolving extension setup requirements. Passed CI checks and was integrated into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Ensures setup hooks are correctly generated when command-chain is present, resolving extension compatibility issues. Maintains 88.88% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2850 hooks: enable command-chain | snapcraft | merged | Merged changes enabling command-chain support in hooks regardless of base. The update passes through user-defined command-chain configurations from snapcraft.yaml without actively enabling it. Approved by one reviewer and passed CI checks. | |
| #3296 meta: write stubs for command-chain using hooks when needed | snapcraft | merged | Merged: implements command-chain stubs using hooks when needed. Approved by one reviewer, modifying three files with 88 additions and 13 deletions to update metadata generation. |