← Back to issue list

extensions: method to get data dir

View original Github issue

Metadata

Project
snapcraft
Number
#3810
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #3810 (CRAFT-1115) merged as commit 0f230edc0, adding get_extensions_data_dir() to snapcraft/extensions/extension.py returning Path(sys.prefix)/share/snapcraft/extensions; now used by gnome, kde_neon, gpu, ros2 and dotnet extensions.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit 0f230edc0 ("extensions: method to get data dir (#3810)"), approved by a reviewer with 0 unresolved comments. The helper is still present in snapcraft/extensions/extension.py and consumed by many extensions (gnome.py:350, gpu_extension.py:141, kde_neon*.py, ros2_*.py, dotnet_base.py).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1115

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3810 (CRAFT-1115) merged as commit 0f230edc0, adding get_extensions_data_dir() to snapcraft/extensions/extension.py returning Path(sys.prefix)/share/snapcraft/extensions; now used by gnome, kde_neon, gpu, ros2 and dotnet extensions.
stealth/space-bunny-alpha — closed resolved Merged into main as commit 0f230edc0, adding get_extensions_data_dir() so extensions can resolve their data directory.
stealth/space-bunny-alpha — closed resolved Merged #3810 as commit 0f230edc, adding a method for extensions to retrieve the data directory.
qwen/qwen3.6-35b-a3b — — Merged an update adding a method to retrieve the extension data directory. After brief discussion on test paths, the reviewer approved the changes, CI passed, and the code was integrated.
qwen3.6-35b-a3b-mtp-q6 — — Merged a PR adding a method to retrieve the extension data directory. Initial test path discrepancies were reviewed but did not prevent the merge.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3811 (confidence 90%)

    Sibling companion PR by the same author merged as c314fd967, adding prepend_to_env/append_to_env helpers alongside this one in extension.py.

  • Related To: snapcraft#4271 (confidence 55%)

    Later commit 4c6b1fdc6 made part_snippet values plugin aware, extending the same extension data-dir plumbing.

Related issues

Issue Project State Summary Similarity
#2349 extensions: use extension docstring snapcraft merged Merged PR #2349 in commit 6e7e30ee1, making snapcraft extensions display extension-specific docstrings and resolving LP #1797655.
71%