Support per-step clean command.
Metadata
Current evaluation
Merged as commit 10772e569: adds a --step argument to `snapcraft clean`, cleaning of reverse dependencies, and placeholder per-step clean rules, advancing LP bug #1537786. Follow-up #401 implemented the real rules and closed the bug.
Resolution: closed resolved
Reason: PR #384 was merged into the branch as commit 10772e569, with maintainers sergiusens and come-maiz approving. Its stated goal — LP bug #1537786 — was completed by merged PR #401 (commit 88d21b180), which implemented the per-part, per-step cleaning rules left as placeholders here.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 10772e569: adds a --step argument to `snapcraft clean`, cleaning of reverse dependencies, and placeholder per-step clean rules, advancing LP bug #1537786. Follow-up #401 implemented the real rules and closed the bug. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as #384 (commit 10772e569), adding clean --step selection, reverse-dependency cleaning, and placeholder per-step rules. Follow-up #401 completed the rules and resolved LP #1537786. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after passing CI and positive reviews. Introduces a --step argument to the clean command, implements reverse dependency cleaning, and adds placeholder per-step clean rules to advance LP #1537786. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into ubuntu-core:feature/1537786/per_step_cleaning. Implemented a --step argument for the clean command, added reverse dependency cleaning, and created placeholder per-step clean rules to advance LP #1537786. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
snapcraft#401
(confidence 90%)
Merged follow-up PR that implemented the per-step clean rules and resolved LP #1537786, which #384 only scaffolded.
-
Related To:
snapcraft#403
(confidence 65%)
Follow-up work adding valid STEP help text to the new `clean -s` option introduced here; itself superseded by #423.
-
Related To:
snapcraft#421
(confidence 55%)
Later fix (commit 6ade3431) for LP #1561328, a bug in the per-step clean state introduced by this work.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #403 Added valid STEPs info to clean command | snapcraft | closed | Valid STEP help text for `snapcraft clean -s` was superseded by merged PR #423, landing as commit 28f568d99. | |
| #1774021 Support automatically cleaning dirty steps | snapcraft (launchpad) | closed | Fixed by automatically cleaning dirty lifecycle steps in snapcraft PR #2145, merged as commit d033c7d0f. | |
| #401 Support per-step cleaning. | snapcraft | merged | Merged PR #401 as 88d21b180, adding per-part, per-step cleaning and resolving Launchpad bug #1537786. | |
| #421 Suggest a full clean if step clean is missing state. | snapcraft | merged | Merged as commit 6ade3431: Snapcraft now suggests a full clean instead of re-running a step when per-step clean state is missing. Fixes LP: #1561328. | |
| #1561328 cleaning a step on a dir built with an old snapcraft doesn't mention that a full clean is needed too | snapcraft (launchpad) | closed | Closed by merged PR #421 (commit 6ade3431), which changed the step-clean error to suggest a full clean instead of re-running the step when state is missing from an older snapcraft build dir. | |
| #2145 lifecycle: automatically clean dirty steps | snapcraft | merged | Merged in canonical/snapcraft#2145 (commit d033c7d0f), adding opt-in outdated_step_action=clean to rebuild changed lifecycle steps and resolve LP #1774021. |