← Back to issue list

Suggest a full clean if step clean is missing state.

View original Github issue

Metadata

Project
snapcraft
Number
#421
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 6ade3431: Snapcraft now suggests a full clean instead of re-running a step when per-step clean state is missing. Fixes LP: #1561328.

Resolution: closed resolved

Reason: PR #421 was merged into snapcraft as commit 6ade3431, updating the per-step clean error suggestions to tell users a full clean is required when state is missing, resolving LP bug #1561328.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently if attempting to run a per-step clean on a tree made dirty by a version of Snapcraft that didn't support per-step cleaning, Snapcraft suggests trying to run that step again. This isn't possible since the step has already been run, so it actually requires a full clean. This PR resolves LP: [#1561328](https://bugs.launchpad.net/snapcraft/+bug/1561328) by updating the suggestions to reflect this fact.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 6ade3431: Snapcraft now suggests a full clean instead of re-running a step when per-step clean state is missing. Fixes LP: #1561328.
stealth/space-bunny-alpha — closed resolved Merged in #421 (6ade3431): Snapcraft now recommends a full clean when per-step cleaning state is missing, resolving LP #1561328.
stealth/space-bunny-alpha — closed resolved PR #421 merged as commit 6ade34314, recommending a full clean when per-step clean state is missing and resolving LP bug #1561328.
stealth/space-bunny-alpha — closed resolved Merged as commit 6ade34314: Snapcraft now recommends a full clean when per-step clean state is missing, addressing LP bug #1561328.
stealth/space-bunny-alpha — closed resolved Merged in PR #1476 (commit 6ade3431), changing missing per-step clean-state suggestions to recommend a full clean, resolving LP bug #1561328.
stealth/space-bunny-alpha — closed resolved Merged in commit 6ade34314: updated Snapcraft’s missing per-step-clean message to recommend a full clean, resolving LP bug #1561328.
qwen/qwen3.6-35b-a3b — — Merged. Updates Snapcraft to suggest a full clean instead of re-running a step when per-step cleaning state is missing, resolving Launchpad bug #1561328.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix that updates Snapcraft to suggest a full clean instead of re-running a step when per-step cleaning state is missing. Resolves Launchpad bug #1561328.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1561328 cleaning a step on a dir built with an old snapcraft doesn't mention that a full clean is needed too snapcraft (launchpad) closed Closed by merged PR #421 (commit 6ade3431), which changed the step-clean error to suggest a full clean instead of re-running the step when state is missing from an older snapcraft build dir.
83%
#384 Support per-step clean command. snapcraft merged Merged as commit 10772e569: adds a --step argument to `snapcraft clean`, cleaning of reverse dependencies, and placeholder per-step clean rules, advancing LP bug #1537786. Follow-up #401 implemented the real rules and closed the bug.
72%
#1647907 When a step is dirty, snapcraft doesn't autoclean and reexecute it snapcraft (launchpad) closed Automatic cleanup and rebuilding of outdated lifecycle steps was implemented in canonical/snapcraft#2145 and merged as d033c7d0f.
71%
#2145 lifecycle: automatically clean dirty steps snapcraft merged Merged in canonical/snapcraft#2145 (commit d033c7d0f), adding opt-in outdated_step_action=clean to rebuild changed lifecycle steps and resolve LP #1774021.
70%