← Back to issue list

store: move package out of commands

View original Github issue

Metadata

Project
snapcraft
Number
#3862
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged a pull request that moved the store package out of the commands directory. Approved by one reviewer, passed CI checks, modified 24 files, and resolves CRAFT-1240.

Suggested action:

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1240

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a pull request that moved the store package out of the commands directory. Approved by one reviewer, passed CI checks, modified 24 files, and resolves CRAFT-1240.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer sergiusens, the store package was relocated from the commands directory. This structural refactor addresses CRAFT-1240 and was integrated directly without additional review comments or revisions.
qwen3.6-35b-a3b-mtp-q6 Merged the store package out of the commands directory. Maintainer sergiusens integrated the change into the main branch, resolving CRAFT-1240.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#94 Store commands autocomplete charmcraft merged Merged the store commands autocomplete implementation. Approved by two reviewers and dependent on PR #93. The commit modifies one file with a +21/-2 line diff, incorporating review feedback from @chipaca.
72%
#89 Store release charmcraft merged Merged after approval by two reviewers. The pull request introduces Store release functionality, modifying 5 files with 196 additions and 1 deletion. No further discussions occurred.
72%
#1358 feat(craft-application): migrate store commands charmcraft merged Migrated store commands in craft-application. Approved by three reviewers and merged, modifying 29 files with 2859 additions and 344 deletions.
71%
#1302 style: clean up store command imports charmcraft merged Merged after approval by two reviewers. The PR cleans up store command imports, modifying one file with 32 additions and 44 deletions. An unrelated codespell lint failure in test_package.py was noted and resolved separately.
71%
#3744 cli: enable craft-store logging snapcraft merged Enabled craft-store logging in the CLI. Merged after reviewer approval and passing CI. The change modifies a single line in one file, maintaining full code coverage.
71%
#1774 chore: remove unused store command implementations charmcraft closed Closed without merge and abandoned. Proposed removing leftover store command implementations no longer needed after the craft-application move. Lacked reviews and CI checks.
70%