← Back to issue list

feat(craft-application): migrate store commands

View original Github issue

Metadata

Project
charmcraft
Number
#1358
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Migrated store commands in craft-application. Approved by three reviewers and merged, modifying 29 files with 2859 additions and 344 deletions.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Migrated store commands in craft-application. Approved by three reviewers and merged, modifying 29 files with 2859 additions and 344 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged migration of store commands in the craft-application module. The pull request by lengau was accepted and integrated into the codebase without comments or revisions.
qwen3.6-35b-a3b-mtp-q6 Migrated store commands within the craft-application package. The pull request was merged by maintainer lengau, successfully implementing the feature without additional discussion or revisions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4614 feat(craft-application): migrate version command snapcraft merged Merged, resolving issue #4468. The version command was migrated to craft-application across seven files. Approved by two reviewers and integrated despite minor Codecov coverage warnings.
82%
#1284 Migrate store commands to craft-application charmcraft closed Closed without resolution or comments after over three years. The store command migration to craft-application was abandoned or completed out-of-band.
80%
#1364 feat(craft-application): miscellaneous commands charmcraft merged Merged after approval by three reviewers. Adds miscellaneous craft-application commands, including analyse and extensions-related features. Changes span 33 files with 943 additions and 249 deletions.
78%
#4830 refactor: migrate commands to craft-application snapcraft merged Merged following three approvals and passing CI. Migrates remaining commands to core24/craft-application, updating snapcraft init to generate core24 files, correcting list-plugins output, and refreshing command docs. Resolves #4742.
76%
#4707 refactor: migrate core22 store commands snapcraft merged Merged a refactor migrating core22 store commands to craft_application.AppCommand. This enables store operations for core24 snaps and fixes a bug where project-agnostic commands like snapcraft login failed in core24 directories.
75%
#1330 feat(craft-app): Add craft-application services charmcraft merged Merged feat(craft-app): Add craft-application services. Approved by two reviewers, the change modified 56 files with 2143 additions and 230 deletions. The author fixed changelist misalignments causing spread test failures before merge.
74%
#1154 Use craft-application's store service charmcraft open Refactor Store class into a craft-application Service and migrate store commands to AppCommand subclasses. Partially done: StoreService exists (PR #1459) and commands are AppCommand subclasses, but the legacy Store class is still used directly in 15+ places in store.py.
74%
#4560 feat(craft-application): initial support snapcraft merged Merged initial craft-application support, acting as a fallback to existing logic. Approved by two reviewers with no unresolved comments. Changes affect 40 files, adding 887 lines and removing 197. Additional features are planned.
74%
#1459 feat: basic store service charmcraft merged Merged an application-agnostic StoreService for executing store commands, configured with Charmcraft defaults. Approved by two reviewers, the update adds 392 lines across eight files.
73%
#1704 craft-application migration cleanup: pack command charmcraft merged Merged cleanup PR removing an outdated pack command retained for comparison during the craft-application migration. Approved by two reviewers with passing CI, the change deletes 1309 lines across six files.
73%