feat(craft-application): migrate store commands
Metadata
Current evaluation
Merged PR #1358 migrated Charmcraft store commands to craft-application, completing #1284; 5cb01186 contains the mechanical migration, and 9da46c37 later removed legacy implementations.
Resolution: closed resolved
Reason: PR #1358 merged after approval by three reviewers, implementing the craft-application migration tracked by #1284. Commit 5cb01186 records the command changes, while 9da46c37 subsequently removed obsolete store implementations.
Evaluated by: mr-cal-bot
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1358 migrated Charmcraft store commands to craft-application, completing #1284; 5cb01186 contains the mechanical migration, and 9da46c37 later removed legacy implementations. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application store-command migration, approved by three reviewers, with 29 files changed (+2,859/-344). | |
| qwen/qwen3.6-35b-a3b | — | — | Migrated store commands in craft-application. Approved by three reviewers and merged, modifying 29 files with 2859 additions and 344 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged migration of store commands in the craft-application module. The pull request by lengau was accepted and integrated into the codebase without comments or revisions. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1284
(confidence 99%)
The tracking issue for this migration was closed after PR #1358 merged.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1284 Migrate store commands to craft-application | charmcraft | closed | Store commands were migrated to craft-application in merged PR #1358 (commit 5cb01186); commit 9da46c37 later removed the unused legacy implementations. | |
| #1154 Use craft-application's store service | charmcraft | open | Store interactions now use a craft-application AppService, and all store commands inherit AppCommand; completed by commit 5dcad2af and related craft-application migration work. | |
| #4468 feature/craft-application: migrate version command | snapcraft | closed | Version command migration to craft-application landed in merged PR #4614 (commit 885106d06), completing the work drafted in 24d48da8 and closing the tracking issue ahead of the craft-application rebase. | |
| #4614 feat(craft-application): migrate version command | snapcraft | merged | Merged PR #4614 (commit 885106d06) migrated Snapcraft's version command to craft-application, resolving #4468; legacy version handling remained out of scope. | |
| #1459 feat: basic store service | charmcraft | merged | Merged in canonical/charmcraft#1459 (5dcad2af), adding a craft-application-style StoreService for store commands with Charmcraft-specific defaults. | |
| #359 Migrate remaining lifecycle commands to craft-application | rockcraft | closed | Resolved by rockcraft PR #395, merged into main; commits e28d53f7 and 0b44fd60 removed legacy lifecycle commands and completed the craft-application migration. | |
| #4830 refactor: migrate commands to craft-application | snapcraft | merged | Merged #4830 as commit 0bee3723c, migrating remaining commands to core24/craft-application; init, list-plugins, and command reference docs now use core24. | |
| #1340 feat(craft-app): move init command | charmcraft | merged | PR #1340 by lengau merged, relocating charmcraft's init command into craft-application (with the init service/command/tests) plus lint fixes (+500/-343, 18 files). Later cleanup commit 97fa9229 (#1520) removed the old implementation. | |
| #1364 feat(craft-application): miscellaneous commands | charmcraft | merged | Merged #1364 into main, adding craft-application analyse and extension-related commands. A charmcraft init failure reported on the PR was addressed by follow-up PR #1367. | |
| #1412 Use upstream craft-application lifecycle commands | charmcraft | closed | Lifecycle migration completed by PR #1538 (5e3b927c); PR #1704 (cfc37020) finished the remaining pack migration cleanup using upstream craft-application commands. |