← Back to issue list

Remove trailing slash from staging STORE_UPLOAD_URL.

View original Github issue

Metadata

Project
snapcraft
Number
#3876
Type
pull request
State
closed
Author
Roadmaster
Labels
—
Created
Updated
Closed

Current evaluation

PR #3876 (strip trailing slash from staging STORE_UPLOAD_URL) was closed unmerged and superseded by merged PR #4201 (commit f88cf20dd), which removed trailing slashes from all staging URLs in tools/staging_env.sh.

Resolution: closed superseded

Reason: The PR was never merged; maintainer @mr-cal closed it noting the problem was resolved by snapcore/snapcraft#4201, which landed as commit f88cf20dd updating the URLs in tools/staging_env.sh.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The trailing slash results in: simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0) because the upload path contains a double slash, in the server logs we see: POST //unscanned-upload/ HTTP/1.1... - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #3876 (strip trailing slash from staging STORE_UPLOAD_URL) was closed unmerged and superseded by merged PR #4201 (commit f88cf20dd), which removed trailing slashes from all staging URLs in tools/staging_env.sh.
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by merged PR #4201, which removed trailing slashes from staging environment URLs, including STORE_UPLOAD_URL.
qwen/qwen3.6-35b-a3b — — Superseded without merging. The trailing slash in STORE_UPLOAD_URL causing JSON decode errors was resolved by pull request #4201.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by pull request #4201. The trailing slash removal in staging STORE_UPLOAD_URL was resolved separately, fixing the double slash that caused a JSONDecodeError.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#4201 (confidence 99%)

    Merged PR removing trailing slashes from all staging env URLs, covering STORE_UPLOAD_URL.

  • Likely Fixed By: f88cf20dd (confidence 95%)

    Commit 'tools: update URLs in tools/staging_env.sh (#4201)' is the merge commit in snapcraft history.

Related issues

Issue Project State Summary Similarity
#4201 Remove trailing slashes from tools/staging_env.sh snapcraft merged Merged PR #4201 (commit f88cf20dd) removed trailing slashes from all staging URLs in tools/staging_env.sh, fixing 405 errors on `snapcraft upload` to the staging Store. Supersedes the earlier unmerged PR #3876.
85%