← Back to issue list

Remove trailing slashes from tools/staging_env.sh

View original Github issue

Metadata

Project
snapcraft
Number
#4201
Type
pull request
State
merged
Author
tartley
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4201 (commit f88cf20dd) removed trailing slashes from all staging URLs in tools/staging_env.sh, fixing 405 errors on `snapcraft upload` to the staging Store. Supersedes the earlier unmerged PR #3876.

Resolution: closed resolved

Reason: The PR was approved and merged as commit f88cf20dd ("tools: update URLs in tools/staging_env.sh (#4201)"); the file now exports STORE_DASHBOARD_URL, STORE_API_URL, STORE_UPLOAD_URL and UBUNTU_ONE_SSO_URL without trailing slashes, fixing the craft-store [405] Method Not Allowed upload failure.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The motivating case was STORE_UPLOAD_URL. With a trailing slash, I fail to upload to the staging Store: snapcraft upload jhartley-two_1.4_amd64.snap craft-store error: Issue encountered while processing your request: [405] Method Not Allowed. I see roadmr already submitted [an old unmerged PR](https://github.com/snapcore/snapcraft/pull/3876) to fix this particular slash, and in the comments @sergiusens asked if he could [remove the all trailing slashes from envvars](https://github.com/snapcore/snapcraft/pull/3876#discussion_r951853960), so this PR does that. --- - [y] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [y] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [NO] Have you successfully run `make lint`? - [NO] Have you successfully run `pytest tests/unit`? I don't have a working snapcraft dev env. Taking a look at what is needed, will update this when I succeed...

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4201 (commit f88cf20dd) removed trailing slashes from all staging URLs in tools/staging_env.sh, fixing 405 errors on `snapcraft upload` to the staging Store. Supersedes the earlier unmerged PR #3876.
stealth/space-bunny-alpha — closed resolved Merged as commit f88cf20dd ("tools: update URLs in tools/staging_env.sh (#4201)"), dropping trailing slashes from STORE_UPLOAD_URL and the other staging env URLs, fixing 405 errors on staging Store uploads.
stealth/space-bunny-alpha — closed resolved Merged PR #4201 removed trailing slashes from staging environment URLs, including STORE_UPLOAD_URL, fixing staging Store uploads that failed with HTTP 405.
qwen/qwen3.6-35b-a3b — — Merged PR #4201 strips trailing slashes from environment variables in tools/staging_env.sh, resolving 405 Method Not Allowed errors during staging Store uploads. Approved following CLA email clarification, with zero coverage impact.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes remove trailing slashes from environment variables in tools/staging_env.sh, resolving 405 upload errors to the staging Store. Maintainer assisted with a CLA email mismatch before merging.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3876 (confidence 92%)

    Earlier unmerged PR by roadmr fixing only the STORE_UPLOAD_URL slash; superseded by #4201, which removed all trailing slashes as suggested by sergiusens in that thread.

Related issues

Issue Project State Summary Similarity
#3876 Remove trailing slash from staging STORE_UPLOAD_URL. snapcraft closed PR #3876 (strip trailing slash from staging STORE_UPLOAD_URL) was closed unmerged and superseded by merged PR #4201 (commit f88cf20dd), which removed trailing slashes from all staging URLs in tools/staging_env.sh.
85%
#3656 tools: update staging store URL for uploading blobs snapcraft merged Merged PR #3656 updated Snapcraft's staging store blob-upload URL; implementation commit 5c4245b67.
75%