← Back to issue list

tests: minor refactoring in shell/shell-after tests

View original Github issue

Metadata

Project
snapcraft
Number
#3904
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged minor test refactoring that parametrizes expected results in shell/shell-after tests instead of computing them at runtime. Approved by one reviewer, passed CI, and modified 24/22 lines with no coverage impact.

Suggested action: —

No scores available.

Issue body

Also parametrize the expected result instead of computing it at test run time. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged minor test refactoring that parametrizes expected results in shell/shell-after tests instead of computing them at runtime. Approved by one reviewer, passed CI, and modified 24/22 lines with no coverage impact.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Refactored shell/shell-after tests by parametrizing expected results instead of computing them at runtime. Code coverage remained unchanged.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Refactored shell/shell-after tests by parametrizing expected results instead of computing them at runtime. Code coverage remained unchanged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3599 desktop: improve shell substitution logic snapcraft merged Merged to master after passing CI and receiving two approvals. The single-line change improves shell substitution logic to resolve shellcheck error SC2295, with no coverage impact.
72%
#81 feat: implement --shell, shell-after, --debug craft-application merged Merged into main, implementing --shell, shell-after, and --debug flags. Approved by two reviewers, passed CI checks, and increased test coverage by 0.05%. Resolves issue #58.
71%