desktop: improve shell substitution logic
Metadata
Current evaluation
Merged to master after passing CI and receiving two approvals. The single-line change improves shell substitution logic to resolve shellcheck error SC2295, with no coverage impact.
Suggested action: —
No scores available.
Issue body
New shellcheck error SC2295.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
-------
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to master after passing CI and receiving two approvals. The single-line change improves shell substitution logic to resolve shellcheck error SC2295, with no coverage impact. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated desktop shell substitution logic to resolve shellcheck error SC2295. Code coverage remained unchanged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master to fix shellcheck error SC2295 by improving shell substitution logic in the desktop component. The change maintains code coverage and passes static and unit tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3904 tests: minor refactoring in shell/shell-after tests | snapcraft | merged | Merged minor test refactoring that parametrizes expected results in shell/shell-after tests instead of computing them at runtime. Approved by one reviewer, passed CI, and modified 24/22 lines with no coverage impact. | |
| #473 Fix shell quoting | snapcraft | merged | Merged a fix for shell quoting that replaces $* with "$@" to prevent unintended IFS splitting when expanding positional arguments. Approved by reviewers and applied across four files. | |
| #2172 many: add shellcheck to static tests | snapcraft | merged | Merged into master. Added shellcheck to static tests to validate shell scripts across 28 files. The change passed CI, received reviewer approval, and slightly increased code coverage. |