parts: minor refactoring in instance log capture
Metadata
Current evaluation
Merged #3905 as bd71c7abc, moving instance log capture into a finally block so it runs once instead of invoking the function twice.
Resolution: closed resolved
Reason: The approved refactor was merged into Snapcraft in commit bd71c7abc, replacing duplicate log-capture calls with a single finally-block call.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Refactor to capture logs in finally block instead of calling the function twice.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3905 as bd71c7abc, moving instance log capture into a finally block so it runs once instead of invoking the function twice. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3905 as bd71c7abc: instance log capture moved to a finally block, replacing duplicate function calls. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged minor refactoring that captures logs in a finally block instead of calling the function twice. Approved by reviewer, passed CI, and changed one file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring that captures instance logs in a finally block instead of calling the function twice. The change improves error handling reliability and was approved without review comments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #893 (internal) Refactor capture_logs_from_instance to use new interface (CRAFT-1306). | charmcraft | merged | Merged #893, refactoring capture_logs_from_instance to use the new CRAFT-1306 interface; implementation commit 5db3467c was merged via 35ed820a. |