← Back to issue list

unit tests: minor improvement to fixture usage

View original Github issue

Metadata

Project
snapcraft
Number
#3910
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged test-only PR #3910 (commit 07d949a71): small refactor of unit-test fixture usage, 8 lines changed across 2 files, no coverage change.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit 07d949a71 ("unit tests: minor improvement to fixture usage (#3910)"), after approval by a maintainer reviewer with no unresolved comments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged test-only PR #3910 (commit 07d949a71): small refactor of unit-test fixture usage, 8 lines changed across 2 files, no coverage change.
stealth/space-bunny-alpha — closed resolved Minor unit-test fixture-usage refactor merged into main as 07d949a71 (PR #3910), updating eight lines across two test files with no measured coverage change.
qwen/qwen3.6-35b-a3b — — Merged into main after passing CI and review. The change refactors unit test fixture usage, modifying 8 lines across 2 files with zero impact on code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. The change applies minor improvements to unit test fixture usage. Codecov analysis confirmed no impact on overall test coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5375 test: fix command tests snapcraft merged Test-only PR by maintainer mr-cal merged as commit 28cb1b828 ("test: fix command tests (#5375)"), updating fixtures for failing command unit tests (CRAFT-4414); +17/-9 across 2 files, approved by 2 reviewers.
72%
#335 tests: broaden scope of fixtures craft-providers merged Merged PR #335 as commit 5d9c9c6, broadening selected test fixture scopes to session scope so setup or skipping occurs before dependent fixtures.
71%
#12 Improved a guard test (fixed the code) and generalized a fixture. craft-cli merged Merged #12: improved a guard test, fixed the tested code, and generalized a fixture for reuse. Included in merge b797c79 via commit f3544ab.
71%
#1391 tests: reduce the amount of test code in test_meta snapcraft merged Merged PR #1391 (commit 4f891d4b1) shrank tests/unit/test_meta.py by 31 net lines (+65/-96), replacing repeated file setup with the new _create_file helper and testtools assertions. Test-only refactor, approved by one reviewer.
70%