← Back to issue list

providers: move mount logic to lifecycle.py

View original Github issue

Metadata

Project
snapcraft
Number
#3930
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged refactoring that relocates snapcraft-specific mount logic to parts/lifecycle.py. Approved after review, passed CI, and achieved 100% diff coverage with a 0.03% overall coverage increase.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Moves the snapcraft-specific calls for mounting directories to `parts/lifecycle.py`. Similar to https://github.com/canonical/rockcraft/pull/82 (CRAFT-1397)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged refactoring that relocates snapcraft-specific mount logic to parts/lifecycle.py. Approved after review, passed CI, and achieved 100% diff coverage with a 0.03% overall coverage increase.
qwen3.6-35b-a3b-mtp-q6 Merged relocation of snapcraft-specific directory mounting logic to parts/lifecycle.py, aligning with rockcraft. The change increased overall test coverage by 0.03% with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged relocation of snapcraft-specific directory mounting logic to parts/lifecycle.py. The update achieved 100% diff coverage, increased overall coverage by 0.03%, and aligns with parallel rockcraft architectural changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#82 providers: move mount logic to lifecycle.py rockcraft merged Merged. Moved project directory mount logic from craft-providers to rockcraft's lifecycle.py, as it is rockcraft-specific. Approved, passed CI, and modified six files with a net reduction of 13 lines.
79%