← Back to issue list

extensions, ros: remove experimental flag

View original Github issue

Metadata

Project
snapcraft
Number
#3988
Type
pull request
State
merged
Author
giusebar
Labels
Created
Updated
Closed

Current evaluation

Merged into main after approval and passing CI. Removes the SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS flag for ROS extensions, enabling stable snap builds without workarounds. Code coverage remains unchanged.

Suggested action:

No scores available.

Issue body

If applied, this commit will allow users to build ros snaps without using the SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS flag. This would help our ROS snap workshops run smoother and avoid the user's feeling that ROS is not currently at in a stable stage. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main after approval and passing CI. Removes the SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS flag for ROS extensions, enabling stable snap builds without workarounds. Code coverage remains unchanged.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Removes the SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS flag for ROS extensions, enabling stable ROS snap builds without workarounds.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Removes the SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS flag for ROS extensions, enabling stable builds without experimental flags. Passes all checks with no coverage impact.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5156 extension: ros2-jazzy remove experimental flag snapcraft merged Merged following two approvals and successful CI checks. The update removes the experimental flag from the ros2-jazzy extension across three files. Author verified unrelated test failures do not affect the change.
77%
#3775 provider: forward SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS snapcraft merged Merged a change forwarding the SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS environment variable to providers, ensuring experimental extensions are properly enabled during builds.
72%
#4221 extensions: support for content sharing for ROS snapcraft merged Merged Sept 14, 2023. Adds ROS content sharing support and snapcraft extensions for core20/22 and colcon/catkin. Rebased onto main and PR #4271, then squash-merged after dual approval. One test disabled due to conflicts.
71%
#4093 cli: add option to enable experimental plugins for snapcraft_legacy snapcraft merged Merged after reviewer approval and passing CI. Adds the --enable-experimental-extensions CLI flag and corresponding environment variable to snapcraft_legacy, enabling experimental plugins for core18 and core20.
71%