← Back to issue list

extensions, ros: remove experimental flag

View original Github issue

Metadata

Project
snapcraft
Number
#3988
Type
pull request
State
merged
Author
giusebar
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 6df1e56d6 ("extensions, ros: remove experimental flag", PR #3988), letting ROS/colcon extensions build without SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS; 13 files, +3/-13.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit 6df1e56d6 by giusebar, with an approving reviewer and no unresolved comments. It dropped the experimental-flag gating from the ROS (core22 ros2-humble/catkin) extension definitions added in #3750, so users no longer need the flag.

Evaluated by: mr-cal-bot

No scores available.

Issue body

If applied, this commit will allow users to build ros snaps without using the SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS flag. This would help our ROS snap workshops run smoother and avoid the user's feeling that ROS is not currently at in a stable stage. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 6df1e56d6 ("extensions, ros: remove experimental flag", PR #3988), letting ROS/colcon extensions build without SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS; 13 files, +3/-13.
stealth/space-bunny-alpha — closed resolved Merged #3988 (commit 436f89b), enabling ROS extensions without SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS and removing their experimental gating.
stealth/space-bunny-alpha — closed resolved Merged into main via commit 6df1e56d6, removing the experimental-extension gate so ROS snaps build without SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS.
stealth/space-bunny-alpha — closed resolved Merged into main in #3988 via commit 6df1e56d6, removing the experimental-extension gate for ROS extensions so ROS snaps build without SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS.
stealth/space-bunny-alpha — closed resolved Merged in #3988: ROS extensions no longer require the experimental flag, allowing ROS snaps to build without SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS.
qwen/qwen3.6-35b-a3b — — Merged into main after approval and passing CI. Removes the SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS flag for ROS extensions, enabling stable snap builds without workarounds. Code coverage remains unchanged.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Removes the SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS flag for ROS extensions, enabling stable ROS snap builds without workarounds.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3750 (confidence 88%)

    PR that added the core22 colcon / ros2-humble experimental extension, the one made non-experimental here

  • Related To: snapcraft#5156 (confidence 80%)

    Later PR (commit 2d5480e68) repeated the same change for the ros2-jazzy extension

  • Related To: snapcraft#3520 (confidence 60%)

    Earlier commit 0662e6307 removed the experimental flag for package-repositories, same pattern

Related issues

Issue Project State Summary Similarity
#5156 extension: ros2-jazzy remove experimental flag snapcraft merged Merged PR #5156 removed the experimental flag from the ROS 2 Jazzy extension in commit 2d5480e68.
77%
#3775 provider: forward SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS snapcraft merged Merged PR #3775, forwarding SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS into provider build environments so experimental extensions work; merge commit 17fe9e48c.
74%
#3197 experimental extension support snapcraft merged Merged PR #3197 (commit be00472e5) added experimental extension support to snapcraft, landed after its prerequisite PR #3196 (c1a41fd84) which unset false boolean CLI flags.
72%
#3266 cli: add --enable-experimental-extensions option for expand-extensions snapcraft merged Merged PR #3266 added --enable-experimental-extensions to expand-extensions, enabling expansion of experimental extensions in commit 31c1eb359.
71%