Tests: Make test_patcher not require a real patchelf in /usr/bin
Metadata
Current evaluation
Merged PR #4003 (commit 237fba4be) made test_patcher independent of a real patchelf in /usr/bin, avoiding PATH-order-dependent test failures.
Resolution: closed resolved
Reason: PR #4003 was merged into main as commit 237fba4be, changing test_patcher so it no longer requires a host-installed patchelf at /usr/bin.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Discovered this accidentally thanks to a `~/.bashrc` that put `/bin` before `/usr/bin` in `$PATH`.
I'm not entirely sure this was unintentional, so unless someone else knows we should probably wait for @sergiusens.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4003 (commit 237fba4be) made test_patcher independent of a real patchelf in /usr/bin, avoiding PATH-order-dependent test failures. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4003 by lengau merged as commit 237fba4be ("unit tests: do not require a real patchelf in /usr/bin"), adding a fake_tools fixture so tests/unit/elf/test_patcher.py no longer needs a real /usr/bin/patchelf and is PATH-order independent. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4003 as commit 237fba4be, removing test_patcher’s reliance on a real /usr/bin/patchelf so the test is independent of PATH ordering. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in 237fba4be (#4003), removing test_patcher's dependency on a real /usr/bin/patchelf and making it insensitive to PATH ordering. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4003 (237fba4be), updating test_patcher to avoid requiring patchelf in /usr/bin and eliminating PATH-order-dependent test failures. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Updates test_patcher to remove the dependency on a system patchelf binary in /usr/bin, resolving a PATH ordering issue. Approved, passed CI, and increased test coverage by 0.61%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for test_patcher to remove its dependency on a real patchelf binary in /usr/bin. This resolves PATH ordering conflicts and increased overall test coverage by 0.61%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5135 fix(test): add patchelf to dev dependencies for testing | snapcraft | closed | Closed unmerged as obsolete after #5225 superseded the proposed patchelf test dependency; the Starflow migration merged in commit 7a1a94e46. |