Tests: Make test_patcher not require a real patchelf in /usr/bin
Metadata
Current evaluation
Merged into main. Updates test_patcher to remove the dependency on a system patchelf binary in /usr/bin, resolving a PATH ordering issue. Approved, passed CI, and increased test coverage by 0.61%.
Suggested action: —
No scores available.
Issue body
Discovered this accidentally thanks to a `~/.bashrc` that put `/bin` before `/usr/bin` in `$PATH`.
I'm not entirely sure this was unintentional, so unless someone else knows we should probably wait for @sergiusens.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Updates test_patcher to remove the dependency on a system patchelf binary in /usr/bin, resolving a PATH ordering issue. Approved, passed CI, and increased test coverage by 0.61%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for test_patcher to remove its dependency on a real patchelf binary in /usr/bin. This resolves PATH ordering conflicts and increased overall test coverage by 0.61%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | PR #4003 merged into main, modifying test_patcher to remove the dependency on a real patchelf binary in /usr/bin. The change resolved a PATH ordering issue and increased overall code coverage by 0.61%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3589 snap: correct patch apply for patchelf | snapcraft | merged | Merged a two-line fix correcting patch application for patchelf. Approved by a reviewer, passed CI, and merged to master. An unrelated test failure was noted but disregarded to proceed. | |
| #5486 build: add patchelf to make dependencies | snapcraft | merged | Merged to add patchelf to development environment dependencies, resolving test failures on self-hosted runners. Approved by two reviewers and passed CI checks. | |
| #5135 fix(test): add patchelf to dev dependencies for testing | snapcraft | closed | Superseded by PR #5225. The pull request adding patchelf to dev dependencies was closed as obsolete after maintainers discussed architectural concerns regarding patchelf usage in tests and development environments. | |
| #1873 elf: cleaner patchelf experience | snapcraft | merged | Merged improvements to patchelf handling. The change uses the system patchelf by default, copies files to prevent hard-link conflicts, and provides fallback instructions. Approved by two reviewers and passed CI checks before merging. |