fix(test): add patchelf to dev dependencies for testing
Metadata
Current evaluation
Closed unmerged as obsolete after #5225 superseded the proposed patchelf test dependency; the Starflow migration merged in commit 7a1a94e46.
Resolution: closed superseded
Reason: The maintainer closed the PR as obsolete because of #5225. That Starflow migration was merged in commit 7a1a94e46 and replaced the proposed dependency change with newer uv-based tooling.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as obsolete after #5225 superseded the proposed patchelf test dependency; the Starflow migration merged in commit 7a1a94e46. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as obsolete: the merged Starflow migration in PR #5225 superseded the proposed patchelf test dependency change. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #5225. The pull request adding patchelf to dev dependencies was closed as obsolete after maintainers discussed architectural concerns regarding patchelf usage in tests and development environments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Added patchelf to dev dependencies to resolve test failures. Discussion highlighted concerns about test isolation and packaging preferences. Closed as obsolete and superseded by #5225. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#5225
(confidence 100%)
The maintainer explicitly identified #5225 as making this PR obsolete; #5225 merged the Starflow migration.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2530 Patchelf test branch | snapcraft | closed | Patchelf test-branch PR #2530 was closed unmerged after years without review or CI; PR #2531 shipped the alternative locally patched Patchelf 0.9 approach in 44be372e3. | |
| #1888 elf: make patchelf a dependency | snapcraft | merged | Merged PR #1888 via commit 7c947f5ec, moving Patchelf out of project_loader build tools and into the deb and snap delivery mechanisms. | |
| #5486 build: add patchelf to make dependencies | snapcraft | merged | Merged PR #5486 (commit 8ae6349b9) adds the patchelf apt package to the Make dev dependencies, fixing test failures on self-hosted CI runners where patchelf was missing. | |
| #4075 tests: mock dependency loading for patch elf test | snapcraft | merged | PR #4075 was merged, mocking dependency loading in a lifecycle patch-ELF test to remove host-dependent ldd behavior and core22-snap requirements. | |
| #4524 test(lifecycle): add test for check patchelf when override | snapcraft | closed | PR #4524 was closed unmerged as outdated; snapcraft#4553 superseded it by adding a warning for override-prime combined with patchelf. | |
| #1983 snap: update revision of patchelf to use | snapcraft | closed | Closed unmerged; the bundled PatchELF revision bump in #1983 was superseded by #2006, which adopted packaging-based acquisition (commit aa2a40322). | |
| #4003 Tests: Make test_patcher not require a real patchelf in /usr/bin | snapcraft | merged | Merged PR #4003 (commit 237fba4be) made test_patcher independent of a real patchelf in /usr/bin, avoiding PATH-order-dependent test failures. | |
| #1864 debian/control: Add patchelf to Depends: | snapcraft | closed | Closed unmerged; the apt dependency change was superseded by #1888 (commit 7c947f5ec), which added Patchelf to Snapcraft's deb and snap delivery mechanisms. |