fix(test): add patchelf to dev dependencies for testing
Metadata
Current evaluation
Superseded by PR #5225. The pull request adding patchelf to dev dependencies was closed as obsolete after maintainers discussed architectural concerns regarding patchelf usage in tests and development environments.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #5225. The pull request adding patchelf to dev dependencies was closed as obsolete after maintainers discussed architectural concerns regarding patchelf usage in tests and development environments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Added patchelf to dev dependencies to resolve test failures. Discussion highlighted concerns about test isolation and packaging preferences. Closed as obsolete and superseded by #5225. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Added patchelf to dev dependencies to resolve test failures. Reviewers raised concerns about test isolation and destructive mode. Superseded by #5225 and closed without merging. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4524 test(lifecycle): add test for check patchelf when override | snapcraft | closed | Closed without merge. The PR added tests for a patchelf behavior during override-prime but remained outdated with unresolved comments, indicating it was abandoned. | |
| #5486 build: add patchelf to make dependencies | snapcraft | merged | Merged to add patchelf to development environment dependencies, resolving test failures on self-hosted runners. Approved by two reviewers and passed CI checks. | |
| #1983 snap: update revision of patchelf to use | snapcraft | closed | Closed without merging. The patchelf revision update received no reviews, comments, or CI checks, indicating it was abandoned or superseded by a later change. | |
| #1888 elf: make patchelf a dependency | snapcraft | merged | Merged after reviewer approval and CI checks. The change corrects patchelf handling by removing it from build_tools and properly configuring it as a dependency via debian/control for deb packages and snapcraft bundling for snaps. | |
| #1864 debian/control: Add patchelf to Depends: | snapcraft | closed | Closed without merging. Maintainers declined adding patchelf to Debian dependencies due to Xenial version constraints, noting it is supplied via build snaps or Docker images. Abandoned in favor of existing distribution methods. | |
| #4003 Tests: Make test_patcher not require a real patchelf in /usr/bin | snapcraft | merged | Merged into main. Updates test_patcher to remove the dependency on a system patchelf binary in /usr/bin, resolving a PATH ordering issue. Approved, passed CI, and increased test coverage by 0.61%. | |
| #2528 packaging: use our patchelf branch | snapcraft | merged | Merged into master to fix s390x build failures by switching patchelf to a custom branch with a failing test disabled. The one-line change was approved, passed CI, and integrated. | |
| #4075 tests: mock dependency loading for patch elf test | snapcraft | merged | Merged a fix for a lifecycle unit test incorrectly loading host dependencies for /bin/true during patch elf testing. The change properly mocks dependency loading, passed CI, and added four lines of code. |