← Back to issue list

lint: reintroduce pylint in tox

View original Github issue

Metadata

Project
snapcraft
Number
#4073
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged into main following approval and passing CI checks. The change reintroduces pylint to the tox configuration, adding 15 lines and removing 1 in a single file. Code coverage remains unchanged.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main following approval and passing CI checks. The change reintroduces pylint to the tox configuration, adding 15 lines and removing 1 in a single file. Code coverage remains unchanged.
qwen3.6-35b-a3b-mtp-q6 Merged into main, reintroducing pylint in tox for project linting. Codecov reported no coverage impact, successfully restoring static analysis tooling to the build configuration.
qwen3.6-35b-a3b-mtp-q6 Merged reintroduction of pylint into tox configuration. Successfully integrated into main without affecting code coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#67 lint: fix ruff linting in tox craft-archives merged Merged after reviewer approval and passing CI. Resolves ruff linting issues in the tox environment by updating three files. Code coverage remains unchanged at 88.07%.
79%
#66 lint: update pylint configuration craft-store merged Merged an update to the pylint configuration, removing 627 lines of outdated settings and adding 16 lines with no functional changes. Approved by a reviewer and passed all CI checks.
76%
#3813 lint: bump pylint snapcraft merged Merged update bumping pylint to the latest version and removing the redundant disable: too-many-lines configuration. Approved, passed CI, and integrated into main as part of core22 architecture support.
74%
#4058 tox: fix linters and makefile snapcraft merged Merged into main after approval and passing CI. Fixes tox linter configurations and updates the Makefile, with no impact on test coverage.
73%
#291 lint: remove leftover pylint directive craft-parts merged Merged a change removing a leftover pylint directive. The single-line deletion across one file received reviewer approval and was integrated after passing checks.
73%
#66 tools: fix ruff linting command in tox starbase merged Merged a one-line fix that corrected the ruff linting command in tox. The change received reviewer approval and was successfully integrated into the codebase.
72%
#2405 feat: merge the 'static' tox environment into the 'lint' one charmcraft merged Merged the static tox environment into the lint environment to integrate pyright type checking into the lint command for machine and kubernetes init profiles. Approved by four reviewers.
71%
#53 tox: move deps from tox.ini into pyproject.toml starbase merged Merged migration of tox dependencies from tox.ini to pyproject.toml. Approved by one reviewer, passed CI checks, and modified two files with a net reduction of ten lines.
71%
#4820 fix(tox): use requirements-devel for linters snapcraft merged Merged a pull request updating the tox configuration to use requirements-devel for linters. Approved by two reviewers and passing CI, the change modifies one file to resolve linting dependencies.
71%
#57 tests: update pylint and address new warnings craft-parts merged Merged after two approvals and passing CI. Updated pylint to 2.8.2 and resolved newly introduced linting warnings in the test suite with minor code adjustments across a single file.
71%