fix(tox): use requirements-devel for linters
Metadata
Current evaluation
PR #4820 merged as commit e6a0f5c3a, adding 4 lines to tox.ini so the lint environment installs linter dependencies from requirements-devel instead of an ad-hoc list. tox.ini was later deleted (18a7596c9).
Resolution: closed resolved
Reason: The PR itself is the fix and it was merged into main as commit e6a0f5c3a ('fix(tox): use requirements-devel for linters (#4820)'), confirmed in the tox.ini commit history. It followed the immediately preceding lint cleanup in #4817, which removed pylint.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #4820 merged as commit e6a0f5c3a, adding 4 lines to tox.ini so the lint environment installs linter dependencies from requirements-devel instead of an ad-hoc list. tox.ini was later deleted (18a7596c9). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4820 in commit e6a0f5c3a, updating tox to install linter dependencies from requirements-devel. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4820, updating tox to use requirements-devel for linters so lint dependencies are provisioned correctly. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a pull request updating the tox configuration to use requirements-devel for linters. Approved by two reviewers and passing CI, the change modifies one file to resolve linting dependencies. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to update the tox configuration, switching linter execution to requirements-devel. The change was accepted and integrated into the main branch. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#4817
(confidence 70%)
Committed just before e6a0f5c3a; 'style: remove pylint' likely prompted the linter dependency cleanup.
-
Superseded By:
canonical/snapcraft#4939
(confidence 45%)
Later commit 8f2afd58a 'build(deps): use the ruff snap (#4939)' moved the ruff linter to a snap, further changing the tox lint env.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4058 tox: fix linters and makefile | snapcraft | merged | PR #4058 by lengau merged as commit be5d4307 ("tox: fix linters and makefile"), correcting linter config in tox.ini and the Makefile after the starbase tox migration (#4046). Codecov reported no coverage change. | |
| #67 lint: fix ruff linting in tox | craft-archives | merged | PR #67 was merged as commit 0148023, fixing Ruff linting configuration in tox. | |
| #47 Fix tox environment setup | craft-cli | merged | Merged PR #47 via commit 32660b2 (merge 4977287), removing stale requirements-file references from tox.ini so tox environment setup works again. | |
| #53 tox: move deps from tox.ini into pyproject.toml | starbase | merged | PR #53 by lengau merged, relocating tox dependency declarations from tox.ini into pyproject.toml (commit 4adb069; +19/-29 across tox.ini and pyproject.toml). | |
| #477 tox: fix broken tox environments | craft-parts | merged | Merged #477 fixed the broken tox environments, updating four files (+8/-3) in commit 64677494. | |
| #84 running tox is broken | craft-providers | closed | Fixed by merged PR #86 (change 1bb3ccf, merge 8e10486), repairing tox's broken requirements.txt dependency after PR #82. | |
| #86 # tox: fix broken dependency on requirements.txt | craft-providers | merged | Merged PR #86 fixed tox's broken requirements.txt dependency handling and restored unit-test execution, resolving #84. | |
| #66 tools: fix ruff linting command in tox | starbase | merged | Merged #66 as commit 189835b, correcting the one-line Ruff lint invocation in tox. | |
| #4073 lint: reintroduce pylint in tox | snapcraft | merged | Merged into main as edd11ada8, reintroducing pylint to the tox lint environment after the tox migration. | |
| #881 build(deps): update dependency tox-gh to ~=1.4.4 (main) | craft-parts | merged | Renovate PR #881 merged into main (commit a222562e), bumping tox-gh in tox.ini from ~=1.3.2 to ~=1.4.4; 1 file changed, approved by 2 reviewers with no failing checks. |