← Back to issue list

Kernel plugin improvements 1

View original Github issue

Metadata

Project
snapcraft
Number
#4081
Type
pull request
State
merged
Author
kubiko
Labels
—
Created
Updated
Closed

Current evaluation

Merged as daa68de70, consolidating kernel plugin code into shared implementations and using textwrap.dedent for readability across five files.

Resolution: closed resolved

Reason: PR #4081 was approved and merged as commit daa68de70, completing the kernel-plugin code consolidation and readability refactor.

Evaluated by: mr-cal-bot

No scores available.

Issue body

code reorganisation: - moving more code to the common implementation - introducing the use of `textwrap.dedent` for code readability

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as daa68de70, consolidating kernel plugin code into shared implementations and using textwrap.dedent for readability across five files.
stealth/space-bunny-alpha — closed resolved Merged #4081 via daa68de70, consolidating kernel plugin code into the common implementation and using textwrap.dedent to improve readability across five files.
stealth/space-bunny-alpha — closed resolved Merged as commit daa68de70 ("kernel plugins: more code consolidation") on 2023-03-29, moving more kernel plugin code into the shared common implementation and adopting textwrap.dedent across 5 files (+1301/-1560).
stealth/space-bunny-alpha — closed resolved Merged in #4081 via commit daa68de70, consolidating kernel plugin code into the common implementation and using textwrap.dedent to improve readability across 5 files.
qwen/qwen3.6-35b-a3b — — Merged after approval. The update reorganizes kernel plugin code by moving implementations to a common module and improves readability with textwrap.dedent. Changes affect 5 files, resulting in a net reduction of 259 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged external contribution by kubiko that reorganizes kernel plugin code by moving shared logic to a common implementation and improves readability using textwrap.dedent. Successfully integrated into the codebase.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3922 (confidence 95%)

    Introduced the v2 and craft-parts kernel plugins whose common implementation was reorganized by #4081.

Related issues

Issue Project State Summary Similarity
#3998 Kernel plugin: multiple fixes snapcraft merged Merged in #3998, fixing #3973's kernel-plugin regression, empty initramfs module crashes, wildcard overlay link errors, documentation, and tests; #4057 later reapplied missed fixes.
71%