← Back to issue list

Kernel plugin improvements 1

View original Github issue

Metadata

Project
snapcraft
Number
#4081
Type
pull request
State
merged
Author
kubiko
Labels
—
Created
Updated
Closed

Current evaluation

Merged after approval. The update reorganizes kernel plugin code by moving implementations to a common module and improves readability with textwrap.dedent. Changes affect 5 files, resulting in a net reduction of 259 lines.

Suggested action: —

No scores available.

Issue body

code reorganisation: - moving more code to the common implementation - introducing the use of `textwrap.dedent` for code readability

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged after approval. The update reorganizes kernel plugin code by moving implementations to a common module and improves readability with textwrap.dedent. Changes affect 5 files, resulting in a net reduction of 259 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged external contribution by kubiko that reorganizes kernel plugin code by moving shared logic to a common implementation and improves readability using textwrap.dedent. Successfully integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 — — Merged code reorganization for the kernel plugin. Changes relocate implementation details to a shared module and apply textwrap.dedent for readability. Successfully integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#837 kernel plugin: allow collecting the same mod deps snapcraft merged Merged kernel plugin fix eliminating duplicate module dependencies via set conversion. Approved by one reviewer. Modifies two files: +36/-1 lines.
78%
#3998 Kernel plugin: multiple fixes snapcraft merged Merged multiple kernel plugin fixes addressing a regression, a crash when no kernel modules are defined, documentation updates, and initramfs overlay warnings. Approved by one reviewer and passed CI checks.
77%
#366 New plugin: kernel snapcraft merged Merged into master, introducing a new kernel plugin with two examples. Jointly developed by Alexander Sack and Sergio Schvezov, the update maintained 95% coverage. After reviewer approval, local test issues were resolved and the code integrated.
76%
#4053 plugins: extract common code from kernel plugins snapcraft merged Merged after extracting and normalizing common functions from legacy v2 and craft-parts kernel plugins, reducing code by over 700 lines across five files. Review approved. Author addressed feedback by reverting an unnecessary codespell pin commit.
74%
#4111 plugins: merge kernel plugin snapcraft merged Merged craft-parts and v2 kernel plugins from a feature branch into main. Approved by one reviewer, passed CI checks, and updated 27 files. Codecov reported a 0.12% coverage increase with 98.32% diff coverage.
74%
#1115 kernel plugin: fix kernel snap layout snapcraft merged Merged fix correcting the kernel plugin snap layout for firmware and modules directories, updating required package lists, and addressing review feedback. Approved, passed CI, and merged after CLA verification.
73%
#1303 kernel plugin: slightly improve the messaging of check_config() snapcraft merged Merged into master. Updates kernel plugin check_config() messaging to specify applicable kernel versions for configuration options. Non-functional text improvement approved by reviewer and integrated with full diff coverage.
73%
#4057 Kernel plugin: reapplying missed fixes snapcraft merged Merged after applying missed kernel plugin fixes: crash prevention, docs, warnings, and Ubuntu Core 20 initramfs improvements. Approved, passed CI, and merged with updated unit tests.
73%
#995 plugins: update kernel plugin to use get_build_properties() snapcraft merged Merged update to the kernel plugin switching it to get_build_properties(), resolving Launchpad bug #1650597. Approved by one reviewer, passed CI, and modified four files with a net coverage increase.
71%
#476 kernel plugin: iterate over modules to add to initrd snapcraft merged Merged updates to the kernel plugin that iterate over modules for initrd inclusion. Approved by @kyrofa following successful tests. Resolves LP #1572118 with 36 additions and 6 deletions across two files.
71%