← Back to issue list

Kernel plugin: multiple fixes

View original Github issue

Metadata

Project
snapcraft
Number
#3998
Type
pull request
State
merged
Author
kubiko
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #3998, fixing #3973's kernel-plugin regression, empty initramfs module crashes, wildcard overlay link errors, documentation, and tests; #4057 later reapplied missed fixes.

Resolution: closed resolved

Reason: PR #3998 merged after approval with no unresolved comments, delivering the kernel-plugin fixes and tests. Follow-up PR #4057 was merged as commit 15e463cb8 to reapply fixes missed from #3998.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Multiple - fixing a regression introduced by #3973. Please do not remove features if not sure about their functionality - fix crash if there are no defined kernel modules to be included in initramfs - improve documentation of multiple options by clarifying default values - fix warning and occasional error reported when linking initramfs overlays with wild cards - updated unit tests for the above changes

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #3998, fixing #3973's kernel-plugin regression, empty initramfs module crashes, wildcard overlay link errors, documentation, and tests; #4057 later reapplied missed fixes.
stealth/space-bunny-alpha — closed resolved Merged #3998 with kernel-plugin regression, empty-module, overlay-wildcard, documentation, and test fixes; later #4057 reapplied missed fixes.
qwen/qwen3.6-35b-a3b — — Merged multiple kernel plugin fixes addressing a regression, a crash when no kernel modules are defined, documentation updates, and initramfs overlay warnings. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged multiple kernel plugin fixes addressing a regression from #3973, a crash when no kernel modules are defined, initramfs overlay wildcard warnings, and documentation clarifications. Unit tests were updated.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4057 (confidence 99%)

    Merged follow-up commit 15e463cb8 reapplied missed kernel and initramfs fixes.

  • Caused By: canonical/snapcraft#3973 (confidence 98%)

    The earlier merged change introduced the regression corrected by #3998.

Related issues

Issue Project State Summary Similarity
#4057 Kernel plugin: reapplying missed fixes snapcraft merged Merged PR #4057 fixed kernel-plugin initramfs handling for empty module lists, wildcard overlays, and UC20 module installation, clarified defaults, and updated tests.
88%
#6254 feat(kernel,initrd): extend plugins with new options, stabilize snapcraft merged PR #6254 merged as commit 518476fc1, adding kernel/initrd plugin options, stability fixes, docs and a new kernel-deb spread test; later landed on main via #6284 (ceace05f3).
72%
#4081 Kernel plugin improvements 1 snapcraft merged Merged as daa68de70, consolidating kernel plugin code into shared implementations and using textwrap.dedent for readability across five files.
71%