← Back to issue list

snapcraft_legacy: inject current snapcraft snap into instances

View original Github issue

Metadata

Project
snapcraft
Number
#4090
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4090 as d680b8437, enabling snapcraft_legacy to inject the current Snapcraft snap into build instances for core18 and core20 snaps.

Resolution: closed resolved

Reason: PR #4090 was approved and merged into main as commit d680b8437, implementing support for installing and injecting the current Snapcraft snap into legacy build instances.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Allow snapcraft to be installed and injected into instances when creating core18|20 snaps. (CRAFT-1661)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4090 as d680b8437, enabling snapcraft_legacy to inject the current Snapcraft snap into build instances for core18 and core20 snaps.
stealth/space-bunny-alpha — closed resolved PR #4090 merged as commit d680b8437, letting snapcraft_legacy install and inject the current snapcraft snap into build instances for core18/core20 snaps (CRAFT-1661); the core22 equivalent landed in merged PR #4084.
stealth/space-bunny-alpha — closed resolved Merged in #4090 as d680b8437, enabling snapcraft_legacy to inject the current snapcraft snap into build instances for core18 and core20 snaps.
qwen/qwen3.6-35b-a3b — — Merged into main. Injects the current snapcraft snap into build instances for core18 and core20 snaps. Approved by two reviewers, passed CI, and modified six files with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main, enabling injection of the current snapcraft snap into instances for core18 and core20 builds. Achieved 100% diff coverage and addresses CRAFT-1661.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4084 (confidence 90%)

    Companion merged change that injected the current Snapcraft snap into build instances for core22 snaps.

Related issues

Issue Project State Summary Similarity
#4084 providers: inject current snapcraft snap into instances snapcraft merged Merged PR #4084 as commit b852f9ac8, injecting the current Snapcraft snap into provider instances so parallel-installed instances can build core22 snaps.
80%
#2285 snapcraft snap: vendor legacy snapcraft snapcraft merged Merged in canonical/snapcraft#2285 (commit 5c1ee3b88), vendoring legacy Snapcraft and dispatching no-base projects to it to preserve backward compatibility.
74%
#1793261 Vendor legacy snapcraft to maintain backward compatibility snapcraft (launchpad) closed Legacy Snapcraft was vendored into the snapcraft snap, dispatching projects without bases to it. Delivered via merged PRs canonical/snapcraft#2283 (commit f9592939a, override-build refactor) and #2285 (commit 5c1ee3b88).
73%
#3579 snap: move base to core20 (CRAFT-509) snapcraft merged Merged PR #3579 via ed2baf8bd, moving Snapcraft's own snap to the core20 base; implementation commit 18a974e01.
71%
#2444 snap: move to core18 snapcraft closed Superseded by merged PR #2712, which moved Snapcraft's snap from core to core18 in commit bd5be51a3.
71%
#1939713 snapcraft init create base: core18 snap snapcraft (launchpad) closed Snapcraft init was updated to scaffold core20 instead of core18 by merged canonical/snapcraft#3587 (merge commit f91632aab).
70%
#2773 build providers: inject snapd snap for latest feature availability snapcraft merged Merged PR #2773 in commit 3740c61bc, replacing injected core snaps with the smaller snapd snap for current build features without requiring core18.
70%