← Back to issue list

snapcraft_legacy: inject current snapcraft snap into instances

View original Github issue

Metadata

Project
snapcraft
Number
#4090
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main. Injects the current snapcraft snap into build instances for core18 and core20 snaps. Approved by two reviewers, passed CI, and modified six files with 100% diff coverage.

Suggested action: —

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Allow snapcraft to be installed and injected into instances when creating core18|20 snaps. (CRAFT-1661)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into main. Injects the current snapcraft snap into build instances for core18 and core20 snaps. Approved by two reviewers, passed CI, and modified six files with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main, enabling injection of the current snapcraft snap into instances for core18 and core20 builds. Achieved 100% diff coverage and addresses CRAFT-1661.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Injects the current snapcraft snap into build instances for core18 and core20 snaps. Passes all unit tests with 100% coverage and addresses CRAFT-1661.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4084 providers: inject current snapcraft snap into instances snapcraft merged Merged. Injects the current snapcraft snap into build instances, enabling core22 builds with a parallel-installed snapcraft instance. Approved, passed CI, and achieved 100% diff coverage. Core18 and core20 support will follow in a subsequent PR.
89%
#3583 build providers: snapcraft's new base is core20 (CRAFT-544) snapcraft merged Merged into master. Replaced core18 injection with core20 as the new snapcraft base. Approved by one reviewer, passed CI, and achieved 100% diff coverage.
75%
#3981 commands, lifecycle: provide snapcraft try for core22 snapcraft merged Merged. Adds snapcraft try support for core22 by mounting a host prime directory into the instance for lifecycle priming without packing. Approved by one reviewer, passed CI, and modified 8 files.
72%
#2285 snapcraft snap: vendor legacy snapcraft snapcraft merged Merged. Vendored legacy snapcraft into the snapcraft snap to resolve LP: #1793261, maintaining support when no base is specified in snapcraft.yaml. Approved by one reviewer and passed CI checks prior to integration.
72%
#3579 snap: move base to core20 (CRAFT-509) snapcraft merged Merged updates the snap base to core20. Approved by two reviewers with passing CI checks. Changes affect 13 files, increase coverage by 0.07%, and update initialization templates to core20.
72%
#2174 build_providers: inject snaps when running from a snap snapcraft merged Merged. Updates build providers to inject snapcraft and its base from the host when running inside the snapcraft snap, ensuring parity with non-snap environments. Approved by reviewer and passed CI checks.
72%
#4024 cli: pass `--verbose` and `-v` to snapcraft_legacy snapcraft merged Merged into main. Enables passing --verbose and -v flags to snapcraft_legacy for core18 and core20 builds. Approved by reviewer, passed CI, and integrated without coverage changes.
72%
#2773 build providers: inject snapd snap for latest feature availability snapcraft merged Merged changes that inject the snapd snap into build providers instead of core, improving feature availability and reducing size. Approved by reviewer, passed CI, and modified 4 files (+59/-12 lines).
71%
#4118 init: use core22 base for `snapcraft init` snapcraft merged Merged. Updates snapcraft init to use core22 as the default base instead of core20. The command was relocated from snapcraft_legacy to snapcraft, and a spread test was added. Approved by reviewer and passed CI.
71%
#1364 lxd: Inject snapcraft and core snaps into the container snapcraft merged Merged. Injects the host's snapcraft and core snaps into LXD containers to ensure build version consistency. Approved by one reviewer, modifying nine files with 360 additions and 46 deletions.
71%