lint: prepare instance for linting a snap file
Metadata
Current evaluation
Merged into main. Updates snapcraft lint to prepare and re-execute inside a snap instance. Approved by a reviewer, passed CI, and increased coverage by 0.02%. Addresses CRAFT-1690.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
`snapcraft lint` now prepares an instance and re-executes `snapcraft lint` inside the instance.
(CRAFT-1690)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main. Updates snapcraft lint to prepare and re-execute inside a snap instance. Approved by a reviewer, passed CI, and increased coverage by 0.02%. Addresses CRAFT-1690. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Configures snapcraft lint to prepare a dedicated instance and re-executes the command within it. Commit 491d50f increased repository coverage by 0.02 percent. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Updates snapcraft lint to prepare an instance and re-execute linting inside it, resolving CRAFT-1690. Codecov reports a 0.02% coverage increase with 98.18% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4115 lint: lint snap files inside an instance | snapcraft | merged | Merged. Implements snapcraft lint execution inside a snap instance, covering unsquashing, metadata collection, installation, linting, and warning reporting. Approved, passed CI, achieved 100% diff coverage, and resolves CRAFT-1689. | |
| #4095 cli: add lint command | snapcraft | merged | Merged into main after approval and passing CI checks. Introduces a new snapcraft lint CLI command, adding 223 lines across 5 files with 96.25% test coverage. Resolves CRAFT-1688. | |
| #3847 linters: add linting infrastructure | snapcraft | merged | Merged. Adds basic linting infrastructure to snapcraft, including a lint entry in snapcraft.yaml to disable specific linters before packing. JSON output is implemented for future use. Approved, rebased, and passed coverage checks. | |
| #5850 style: fix pending lints from snapcraft itself | snapcraft | merged | Merged changes fixing pending snapcraft lint warnings for unused libraries and missing metadata fields. Approved by two reviewers, passed CI checks, and added 10 lines to one file. | |
| #4 snap: introduce initial snap packaging (CRAFT-578) | rockcraft | merged | Merged initial snap packaging implementation (CRAFT-578). Approved by one reviewer, passed CI checks, and added 86 lines across three files. | |
| #4022 lint: ignore snapd-testing-tools, venv | snapcraft | merged | Merged linter configuration updates to ignore venv, snapd-testing-tools, and cache directories, resolving local development failures. Approved by reviewers, passed CI, and integrated into main. | |
| #776 Updated the contents of the snapcraft init template | snapcraft | merged | Merged update to the snapcraft init template. The maintainer modified 44 lines across three files to align with LP #1620428. Changes were integrated after a retest request, with no blocking CI failures or unresolved review comments. | |
| #228 packages: run snap operations silently | craft-parts | merged | Merged to fix #218 by running snap subprocesses silently, preventing stdout leakage that conflicts with craft-cli during lifecycle execution. Approved by one reviewer, passed CI, and modified two files (+32/-15 lines). | |
| #2411 cli: snapcraft init with a base | snapcraft | merged | Merged. Adds a syntax documentation link after snapcraft init execution. Approved by one reviewer, passed CI checks, modified five files, and achieved 100% diff coverage. Resolves LP #1803776. |