← Back to issue list

cli: add lint command

View original Github issue

Metadata

Project
snapcraft
Number
#4095
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4095 (commit 297130c4e) adding the `snapcraft lint` CLI command with unit tests for CRAFT-1688, giving Snapcraft users access to lint checks.

Resolution: closed resolved

Reason: The pull request was approved and merged into main as commit 297130c4e ("cli: add lint command (#4095)"), confirmed by the merge commit found in snapcraft's git history; the Codecov comment is the only feedback and is purely informational.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Add CLI handling for a new command, `snapcraft lint`. (CRAFT-1688)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4095 (commit 297130c4e) adding the `snapcraft lint` CLI command with unit tests for CRAFT-1688, giving Snapcraft users access to lint checks.
stealth/space-bunny-alpha — closed resolved Merged PR #4095 (commit 297130c4e), adding a snapcraft lint CLI command and tests for CRAFT-1688.
stealth/space-bunny-alpha — closed resolved Merged into main as commit 297130c4e, adding the `snapcraft lint` CLI command and its tests for CRAFT-1688.
qwen/qwen3.6-35b-a3b — — Merged into main after approval and passing CI checks. Introduces a new snapcraft lint CLI command, adding 223 lines across 5 files with 96.25% test coverage. Resolves CRAFT-1688.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main, adding a snapcraft lint CLI command. The change passed lint and unit tests, achieved 96.25% coverage, and was submitted by maintainer mr-cal.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4269 (confidence 45%)

    Later commit 66bea8b17 'feat(lint): migrate lint command' supersedes the initial implementation, indicating the feature was later reworked.

Related issues

Issue Project State Summary Similarity
#3847 linters: add linting infrastructure snapcraft merged Merged into main as 9f70a0422, adding the linting framework, snapcraft.yaml lint configuration, pre-pack lint execution, and JSON-formatted issue output.
75%
#4101 lint: prepare instance for linting a snap file snapcraft merged Merged #4101 as caa2f2e9d, making snapcraft lint prepare an instance and re-execute lint inside it for CRAFT-1690.
74%
#2002 many: add snapcraftctl command for scriptlets snapcraft merged Merged PR #2002 (commit bbca282fa) added the snapcraftctl CLI for scriptlets to talk to the parent Snapcraft process, including `snapcraftctl build` and the override-build scriptlet. Resolved #1675 and LP #1751749.
72%
#5850 style: fix pending lints from snapcraft itself snapcraft merged Merged PR #5850 as commit bc10f1dc1, resolving Snapcraft's pending lint warnings by excluding unused ICU libraries and adding missing contact and donation metadata.
71%