← Back to issue list

cli: add lint command

View original Github issue

Metadata

Project
snapcraft
Number
#4095
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main after approval and passing CI checks. Introduces a new snapcraft lint CLI command, adding 223 lines across 5 files with 96.25% test coverage. Resolves CRAFT-1688.

Suggested action: —

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Add CLI handling for a new command, `snapcraft lint`. (CRAFT-1688)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into main after approval and passing CI checks. Introduces a new snapcraft lint CLI command, adding 223 lines across 5 files with 96.25% test coverage. Resolves CRAFT-1688.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main, adding a snapcraft lint CLI command. The change passed lint and unit tests, achieved 96.25% coverage, and was submitted by maintainer mr-cal.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Adds CLI handling for the snapcraft lint command. Passed lint and unit tests, with Codecov reporting 96.25% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4101 lint: prepare instance for linting a snap file snapcraft merged Merged into main. Updates snapcraft lint to prepare and re-execute inside a snap instance. Approved by a reviewer, passed CI, and increased coverage by 0.02%. Addresses CRAFT-1690.
84%
#3847 linters: add linting infrastructure snapcraft merged Merged. Adds basic linting infrastructure to snapcraft, including a lint entry in snapcraft.yaml to disable specific linters before packing. JSON output is implemented for future use. Approved, rebased, and passed coverage checks.
80%
#4115 lint: lint snap files inside an instance snapcraft merged Merged. Implements snapcraft lint execution inside a snap instance, covering unsquashing, metadata collection, installation, linting, and warning reporting. Approved, passed CI, achieved 100% diff coverage, and resolves CRAFT-1689.
78%
#5850 style: fix pending lints from snapcraft itself snapcraft merged Merged changes fixing pending snapcraft lint warnings for unused libraries and missing metadata fields. Approved by two reviewers, passed CI checks, and added 10 lines to one file.
76%
#2002 many: add snapcraftctl command for scriptlets snapcraft merged Merged. Adds snapcraftctl CLI for scriptlet-to-Snapcraft communication. Introduces snapcraftctl build for override-build, resolving #1675 and LP: #1751749. Approved with passing CI across 28 files.
72%
#292 extensions: add cli commands rockcraft merged Merged addition of list-extensions and expand-extensions CLI commands matching Snapcraft semantics, plus test refactoring. Resolves #274. Approved by two reviewers, passed CI, and modified 15 files (+452/-109 lines).
72%
#2411 cli: snapcraft init with a base snapcraft merged Merged. Adds a syntax documentation link after snapcraft init execution. Approved by one reviewer, passed CI checks, modified five files, and achieved 100% diff coverage. Resolves LP #1803776.
72%
#5 style(lint): fix linting issues starflow merged Merged after approval. Resolved linting issues by modifying one file with three additions and three deletions. No unresolved comments or CI checks were present.
71%