← Back to issue list

plugins: kernel plugin fixes and spread tests

View original Github issue

Metadata

Project
snapcraft
Number
#4104
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4104 (commit ad47bfae7, CRAFT-1619): added software-properties-common install, fixed core22 shell script issues in the v2/craft-parts kernel plugins, and added manual spread tests.

Resolution: closed resolved

Reason: The pull request itself was merged into snapcraft as commit ad47bfae7 ('plugins: kernel plugin fixes and spread tests (#4104)'), landing the core22 shell fixes, software-properties-common build package, and new spread tests. It also carried over the package-install code from unmerged PR #4064.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Install the software-properties-common package, address shell script issues when running on base core22, and create spread tests for v2 and craft-parts kernel plugins. Package installation code from PR #4064 by dbruno74. Spread tests are set to manual and will run periodically. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1619

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4104 (commit ad47bfae7, CRAFT-1619): added software-properties-common install, fixed core22 shell script issues in the v2/craft-parts kernel plugins, and added manual spread tests.
stealth/space-bunny-alpha — closed resolved Merged as commit ad47bfae7 (CRAFT-1619): fixed core22 shell script issues in the kernel plugin, installed software-properties-common (code from #4064), and added manual spread tests for the v2 and craft-parts kernel plugins.
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#4104, fixing core22 kernel-plugin shell issues, installing software-properties-common, and adding manual spread tests for v2 and craft-parts plugins.
qwen/qwen3.6-35b-a3b — — Merged after approval. Resolves core22 kernel plugin shell script issues, adds software-properties-common installation, and introduces spread tests for v2 and craft-parts kernel plugins. Credits PR #4064. CI passed.
qwen3.6-35b-a3b-mtp-q6 — — Merged kernel plugin fixes resolving core22 shell script issues and adding the software-properties-common dependency. Implemented manual spread tests for v2 and craft-parts kernel plugins. Changes successfully integrated.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3922 (confidence 70%)

    The v2 and craft-parts kernel plugins being fixed and tested here were introduced in #3922.

Related issues

Issue Project State Summary Similarity
#4111 plugins: merge kernel plugin snapcraft merged Merged PR #4111 into main, landing the craft-parts and v2 kernel plugin changes from the feature branch.
76%
#4053 plugins: extract common code from kernel plugins snapcraft merged Merged as commit 8254d5dfb: consolidated common code between the legacy v2 and craft-parts kernel plugins (+1134/-1908, 5 files), per CRAFT-1617/CRAFT-1618. Follow-up refactors landed in #4081 and #4164.
73%
#4112 plugins: kernel plugin: fix core20 base builds snapcraft merged Merged PR #4112 as commit 577c6c22e, fixing core20 kernel builds to invoke apt-get with sudo only when required.
73%
#6254 feat(kernel,initrd): extend plugins with new options, stabilize snapcraft merged PR #6254 merged as commit 518476fc1, adding kernel/initrd plugin options, stability fixes, docs and a new kernel-deb spread test; later landed on main via #6284 (ceace05f3).
72%
#6418 core26: kernel plugin fails to run snapcraft closed Fixed by merged PR canonical/snapcraft#6425 (commit be405aad6), updating the kernel plugin to handle modules packaged under usr/lib on usrmerged core26 systems.
71%
#366 New plugin: kernel snapcraft merged Merged PR #366 by sergiusens into master via merge commit b7c1e8bbb (head commit 6da4ee672), adding the new kernel and kbuild snapcraft plugins with two example projects, closing LP #1552168.
70%
#13 test(spread): add more spread tests snapcraft-rocks merged Merged PR #13 added Spread tests for architectures, Chisel slices, craftctl, package repositories, and patchelf (+206/-5 across 15 files).
70%