← Back to issue list

plugins: kernel plugin: fix core20 base builds

View original Github issue

Metadata

Project
snapcraft
Number
#4112
Type
pull request
State
merged
Author
kubiko
Labels
Created
Updated
Closed

Current evaluation

Merged fix for core20 base build failures caused by a missing sudo check during software-properties-common installation. Rebased to resolve conflicts with #4111, approved, and merged into main.

Suggested action:

No scores available.

Issue body

Builds for core20 are often run without `sudo` when adding ppa, we determine if sudo should be used to invoke `apt-get` The new install step for `software-properties-common` package is missing this check, breaking existing builds without `sudo`

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for core20 base build failures caused by a missing sudo check during software-properties-common installation. Rebased to resolve conflicts with #4111, approved, and merged into main.
qwen3.6-35b-a3b-mtp-q6 Merged after rebasing to resolve conflicts with PR #4111. Fixes core20 base build failures without sudo by adding the missing sudo check to the software-properties-common installation step in the kernel plugin.
qwen3.6-35b-a3b-mtp-q6 Merged after resolving a conflict with #4111. Fixed a kernel plugin bug where the software-properties-common installation step lacked a sudo check, breaking core20 base builds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4104 plugins: kernel plugin fixes and spread tests snapcraft merged Merged after approval. Resolves core22 kernel plugin shell script issues, adds software-properties-common installation, and introduces spread tests for v2 and craft-parts kernel plugins. Credits PR #4064. CI passed.
75%
#6089 fix(plugins/python): fix core26 builds snapcraft merged Merged to enable the Python plugin for strictly confined core26 snaps and add core26 spread tests. Approved by three reviewers, passed CI, and resolves #6020.
72%
#4057 Kernel plugin: reapplying missed fixes snapcraft merged Merged after applying missed kernel plugin fixes: crash prevention, docs, warnings, and Ubuntu Core 20 initramfs improvements. Approved, passed CI, and merged with updated unit tests.
71%
#2368 {kbuild,kernel} plugin: add support for bases snapcraft merged Merged after review and CI approval, adding core16 and core18 base support to the KBuild and Kernel plugins. Resolved Launchpad bugs #1794790 and #1794791 across 7 files with 100% diff coverage.
71%
#3870 plugins command: support for core22 snapcraft merged Merged changes adding core22 support to the plugins command and clarifying base selection messages. Approved by a reviewer, passed CI, and integrated into main despite a minor 0.04% coverage decrease.
71%