plugins: kernel plugin: fix core20 base builds
Metadata
Current evaluation
Merged PR #4112 as commit 577c6c22e, fixing core20 kernel builds to invoke apt-get with sudo only when required.
Resolution: closed resolved
Reason: The approved PR was merged into main as commit 577c6c22e. It restores sudo-aware apt-get invocation for the software-properties-common install step.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Builds for core20 are often run without `sudo` when adding ppa, we determine if sudo should be used to invoke `apt-get`
The new install step for `software-properties-common` package is missing this check, breaking existing builds without `sudo`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4112 as commit 577c6c22e, fixing core20 kernel builds to invoke apt-get with sudo only when required. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4112 fixed core20 kernel plugin builds by using the existing sudo decision when apt-get installs software-properties-common. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4112 merged into main, fixing core20 kernel-plugin builds by applying the existing apt-get sudo decision when installing software-properties-common. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for core20 base build failures caused by a missing sudo check during software-properties-common installation. Rebased to resolve conflicts with #4111, approved, and merged into main. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after rebasing to resolve conflicts with PR #4111. Fixes core20 base build failures without sudo by adding the missing sudo check to the software-properties-common installation step in the kernel plugin. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#4111
(confidence 98%)
This preceding kernel-plugin merge caused a conflict; #4112 was rebased before approval and merge.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6425 fix(plugins/kernel): handle usrmerge | snapcraft | closed | Merged as be405aad6 via #6425, updating kernel-plugin paths to support usrmerged Linux packages and fix core26 build failures. | |
| #6418 core26: kernel plugin fails to run | snapcraft | closed | Fixed by merged PR canonical/snapcraft#6425 (commit be405aad6), updating the kernel plugin to handle modules packaged under usr/lib on usrmerged core26 systems. | |
| #4104 plugins: kernel plugin fixes and spread tests | snapcraft | merged | Merged PR #4104 (commit ad47bfae7, CRAFT-1619): added software-properties-common install, fixed core22 shell script issues in the v2/craft-parts kernel plugins, and added manual spread tests. | |
| #2368 {kbuild,kernel} plugin: add support for bases | snapcraft | merged | Merged #2368 as ddbda36b5, adding core16/core18 base support to the KBuild and inherited Kernel plugins and resolving LP bugs #1794790/#1794791. | |
| #1624 kernel plugin: use latest stable core snap | snapcraft | merged | Merged PR #1624 via commit aa8a8429b, changing the kernel plugin to use the stable core snap instead of obsolete ubuntu-core and updating tests. |