← Back to issue list

kernel plugin: call deb rules clean

View original Github issue

Metadata

Project
snapcraft
Number
#4117
Type
pull request
State
merged
Author
kubiko
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit e080e5a70: kernel plugin's kconfigflavour build now runs `fakeroot debian/rules clean` so SYSTEM_TRUSTED_KEYS/REVOCATION_KEYS are set by deb rules, removing the need to mod configs. Follow-up #4210 reworked Ubuntu config generation.

Resolution: closed resolved

Reason: PR #4117 was approved and merged into main as commit e080e5a70 ("kernel plugin: call 'debian/rules clean' for kconfigflavour"), touching kernel_build.sh and 4 other files (+38/-6). The merged code is present today at snapcraft/parts/plugins/kernel_build.sh, where `fakeroot debian/rules clean genconfigs` and `fakeroot debian/rules clean` run during Ubuntu config generation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

when building kernel with `kconfigflavour` Ubuntu config option, the kernel tree should also contain `debian/rules` call `debian/rules clean` if `debian/rules` exist so `SYSTEM_TRUSTED_KEYS` and `SYSTEM_REVOCATION_KEYS` configs do not need to be modded.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit e080e5a70: kernel plugin's kconfigflavour build now runs `fakeroot debian/rules clean` so SYSTEM_TRUSTED_KEYS/REVOCATION_KEYS are set by deb rules, removing the need to mod configs. Follow-up #4210 reworked Ubuntu config generation.
stealth/space-bunny-alpha — closed resolved Merged #4117 in commit e080e5a70, adding debian/rules clean for Ubuntu kconfigflavour kernel builds so Debian rules handle trusted and revocation keys.
qwen/qwen3.6-35b-a3b — — Merged: kubiko's contribution adds a debian/rules clean call during kernel builds to automate SYSTEM_TRUSTED_KEYS and SYSTEM_REVOCATION_KEYS handling for Ubuntu kconfigflavour. Approved, rebased to main, and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged after rebasing to main. Adds a debian/rules clean call during kernel builds when the file exists, eliminating manual modifications to SYSTEM_TRUSTED_KEYS and SYSTEM_REVOCATION_KEYS. Code coverage unchanged.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4210 (confidence 78%)

    Follow-up merged as da9006784 ("kernel plugin: properly generate Ubuntu kernel .config") that reworked the same Ubuntu config path, superseding parts of the approach introduced here.

  • Related To: canonical/snapcraft#4185 (confidence 60%)

    Commit 389462c51 added a debhelper build dependency for the kernel plugin, likely needed to make debian/rules invocations work.

Related issues

Issue Project State Summary Similarity
#4210 kernel plugin: properly generate Ubuntu kernel .config snapcraft merged Merged #4210 as da9006784, replacing manual config assembly with debian/rules genconfigs for Jammy+ annotation-based Ubuntu kernels.
74%
#4185 kernel plugin: add debhelper build dependency snapcraft merged Merged PR #4185 in commit 389462c51, adding debhelper as a kernel-plugin build dependency required by debian/rules clean.
74%
#1219 kernel plugin: learn how to assemble the ubuntu config using kconfigflavour snapcraft closed PR closed unmerged after changes were requested (3 open review comments). The same kconfigflavour-based Ubuntu config assembly landed later via snapcraft#1285 (commit bc553a1c6), closing LP #1675454.
72%
#1285 kernel plugin: learn how to assemble the ubuntu config using kconfigflavour snapcraft merged Merged in #1285 as bc553a1c6, adding kconfigflavour support to assemble Ubuntu kernel configs from Debian config files without wrapper scripts.
71%