← Back to issue list

kernel plugin: call deb rules clean

View original Github issue

Metadata

Project
snapcraft
Number
#4117
Type
pull request
State
merged
Author
kubiko
Labels
Created
Updated
Closed

Current evaluation

Merged: kubiko's contribution adds a debian/rules clean call during kernel builds to automate SYSTEM_TRUSTED_KEYS and SYSTEM_REVOCATION_KEYS handling for Ubuntu kconfigflavour. Approved, rebased to main, and merged.

Suggested action:

No scores available.

Issue body

when building kernel with `kconfigflavour` Ubuntu config option, the kernel tree should also contain `debian/rules` call `debian/rules clean` if `debian/rules` exist so `SYSTEM_TRUSTED_KEYS` and `SYSTEM_REVOCATION_KEYS` configs do not need to be modded.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged: kubiko's contribution adds a debian/rules clean call during kernel builds to automate SYSTEM_TRUSTED_KEYS and SYSTEM_REVOCATION_KEYS handling for Ubuntu kconfigflavour. Approved, rebased to main, and merged.
qwen3.6-35b-a3b-mtp-q6 Merged after rebasing to main. Adds a debian/rules clean call during kernel builds when the file exists, eliminating manual modifications to SYSTEM_TRUSTED_KEYS and SYSTEM_REVOCATION_KEYS. Code coverage unchanged.
qwen3.6-35b-a3b-mtp-q6 Merged after rebase to main. Introduces a call to debian/rules clean during kernel builds to automatically manage SYSTEM_TRUSTED_KEYS and SYSTEM_REVOCATION_KEYS, removing the need for manual configuration changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4185 kernel plugin: add debhelper build dependency snapcraft merged Merged into hotfix/7.4 after reviewer approval and passing CI. Adds debhelper as a build dependency for the kernel plugin to satisfy debian/rules clean requirements. Author rebased to resolve conflicts before final merge.
74%
#1285 kernel plugin: learn how to assemble the ubuntu config using kconfigflavour snapcraft merged Merged. Replaces shell script wrappers in the snapcraft kernel plugin with direct extraction of Ubuntu kernel configs from debian config files using the kconfigflavour parameter. Approved by reviewers and merged after passing CI.
71%
#1219 kernel plugin: learn how to assemble the ubuntu config using kconfigflavour snapcraft closed Closed without merging due to unresolved review feedback. The pull request proposed refactoring the kernel plugin to extract Ubuntu configuration from debian config directories instead of shell scripts, but requested changes were never addressed.
71%