← Back to issue list

kernel plugin: learn how to assemble the ubuntu config using kconfigflavour

View original Github issue

Metadata

Project
snapcraft
Number
#1219
Type
pull request
State
closed
Author
piso77
Labels
—
Created
Updated
Closed

Current evaluation

PR closed unmerged after changes were requested (3 open review comments). The same kconfigflavour-based Ubuntu config assembly landed later via snapcraft#1285 (commit bc553a1c6), closing LP #1675454.

Resolution: closed superseded

Reason: The PR was abandoned with review status 'changes_requested' and 3 unresolved comments. Maintainers reworked and merged the identical feature in snapcraft#1285 as commit bc553a1c6, which taught the kernel plugin to assemble the Ubuntu config from the debian.$branch/config dir via kconfigflavour and resolved LP bug #1675454.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Instead of gluing together shell scripts or anything, simply teach snapcraft how to extract the entire ubuntu config from debian.$branch/config dir. Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> LP: #1675454

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR closed unmerged after changes were requested (3 open review comments). The same kconfigflavour-based Ubuntu config assembly landed later via snapcraft#1285 (commit bc553a1c6), closing LP #1675454.
stealth/space-bunny-alpha — closed superseded PR #1219 proposing kconfigflavour-based Ubuntu kernel config assembly in the kernel plugin was closed unmerged after 3 review requests; the same feature landed later via merged PR #1285 (commit bc553a1c6).
stealth/space-bunny-alpha — closed superseded Closed unmerged after 3 review requests; equivalent kconfigflavour-based kernel-plugin work later landed in snapcraft#1285 at bc553a1c6.
stealth/space-bunny-alpha — closed resolved Merged in #1285 as bc553a1c6, adding kconfigflavour support to assemble Ubuntu kernel configs from Debian config files.
qwen/qwen3.6-35b-a3b — — Closed without merging due to unresolved review feedback. The pull request proposed refactoring the kernel plugin to extract Ubuntu configuration from debian config directories instead of shell scripts, but requested changes were never addressed.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned. Proposed updating the snapcraft kernel plugin to extract the full Ubuntu kernel configuration from the debian.$branch/config directory, replacing manual shell script assembly. Closed without merging or further activity.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#1285 (confidence 97%)

    Same title and goal; merged as commit bc553a1c6 adding kconfigflavour support to the kernel plugin.

  • Duplicate Of: snapcraft#1285 (confidence 90%)

    Functionally the same change, reworked and merged after review feedback on this PR.

  • Related To: snapcraft (launchpad)#1675454 (confidence 60%)

    LP bug #1675454 cited in this PR body; closed by the merged #1285.

  • Related To: snapcraft#4117 (confidence 55%)

    Follow-up commit e080e5a70 'kernel plugin: call debian/rules clean for kconfigflavour' extending the kconfigflavour-based config handling.

Related issues

Issue Project State Summary Similarity
#1285 kernel plugin: learn how to assemble the ubuntu config using kconfigflavour snapcraft merged Merged in #1285 as bc553a1c6, adding kconfigflavour support to assemble Ubuntu kernel configs from Debian config files without wrapper scripts.
87%
#1675454 Teach snapcraft's kernel plugins how to extract the Ubuntu config from the debian dirs snapcraft (launchpad) closed Kernel plugins learned to assemble Ubuntu configs with kconfigflavour via snapcore/snapcraft#1285 (commit bc553a1c6).
74%
#4117 kernel plugin: call deb rules clean snapcraft merged Merged as commit e080e5a70: kernel plugin's kconfigflavour build now runs `fakeroot debian/rules clean` so SYSTEM_TRUSTED_KEYS/REVOCATION_KEYS are set by deb rules, removing the need to mod configs. Follow-up #4210 reworked Ubuntu config generation.
72%
#4210 kernel plugin: properly generate Ubuntu kernel .config snapcraft merged Merged #4210 as da9006784, replacing manual config assembly with debian/rules genconfigs for Jammy+ annotation-based Ubuntu kernels.
72%
#1689564 kernel plugin: check_config(): improve the messaging for some CONFIG_* option snapcraft (launchpad) closed Messaging-only change to kernel plugin check_config() landed via GitHub PR snapcore/snapcraft#1303, merged as commit 05c94178; maintainer sergiusens linked the PR and closed LP #1689564.
71%
#378 New plugin: kbuild snapcraft merged Added and merged the kbuild plugin in snapcraft#378 via implementation c4614c58d and merge 5b3dd6aa1, including kernel config handling and tests.
70%