← Back to issue list

meta: omit LD_LIBRARY_PATH and PATH in classic confinement

View original Github issue

Metadata

Project
snapcraft
Number
#4216
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4216 (commit 9b6e58337) omits default LD_LIBRARY_PATH and PATH for classic-confinement snaps, resolving #4187.

Resolution: closed resolved

Reason: PR #4216 was approved and merged as commit 9b6e58337. It stops Snapcraft from adding default LD_LIBRARY_PATH and PATH values to classically confined snaps.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- When confinement is classic, do not use the default values for `LD_LIBRARY_PATH` and `PATH`. Includes an optimization/refactor suggestion from my original implementation: https://github.com/snapcore/snapcraft/pull/3758#discussion_r881900290 Resolves https://github.com/snapcore/snapcraft/issues/4187 (CRAFT-1774)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4216 (commit 9b6e58337) omits default LD_LIBRARY_PATH and PATH for classic-confinement snaps, resolving #4187.
stealth/space-bunny-alpha — closed resolved Merged PR #4216 as commit 9b6e58337, omitting default LD_LIBRARY_PATH and PATH for classic-confinement snaps and resolving #4187.
stealth/space-bunny-alpha — closed resolved PR #4216 by mr-cal merged (commit 9b6e58337), omitting default LD_LIBRARY_PATH and PATH for classic-confinement snaps; fixes #4187 (CRAFT-1774).
stealth/space-bunny-alpha — closed resolved Merged PR #4216 as commit 9b6e58337, omitting default LD_LIBRARY_PATH and PATH for classic confinement and fixing #4187.
stealth/space-bunny-alpha — closed resolved Merged as commit 9b6e5833, stopping Snapcraft from adding default PATH and LD_LIBRARY_PATH values to classic snaps, resolving #4187.
qwen/qwen3.6-35b-a3b — — Merged to omit default LD_LIBRARY_PATH and PATH in classic confinement, resolving #4187. Post-merge comments warn the change may break existing classic snaps relying on the previous PATH behavior.
qwen3.6-35b-a3b-mtp-q6 — — Merged to omit default LD_LIBRARY_PATH and PATH in classic confinement, resolving issue #4187. Post-merge feedback indicates the change may break existing classic snaps relying on these environment variables.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcore/snapcraft#4187 (confidence 100%)

    The PR explicitly resolves this issue with the classic-confinement environment change.

  • Related To: snapcore/snapcraft#3758 (confidence 95%)

    Its review discussion contributed an optimization and refactoring suggestion incorporated into PR #4216.

Related issues

Issue Project State Summary Similarity
#4187 Environment is being set for classic snaps snapcraft closed Classic-confinement snaps no longer receive top-level LD_LIBRARY_PATH and PATH; fixed by merged PR #4216 in commit 9b6e58337.
80%
#1635 snap: remove leaking LD_LIBRARY_PATH snapcraft merged Merged as da9181487: PR #1635 removed LD_LIBRARY_PATH leakage from snapcraft-classic, fixing LP #1723208 and preventing breakage on hosts such as Trusty.
74%
#1094 core: switch to using rpath for clasic confinement. snapcraft merged Merged PR #1094 (commit e174e46e6) switched core classic confinement from RUNPATH to RPATH, addressing LP #1657504.
72%
#946 meta: support classic confinment snapcraft merged Merged snapcraft#946 via commit 97af16ffe added classic confinement metadata support, allowing meta snaps to declare confinement as classic (LP #1647422).
72%
#1647422 Support classic confinement snapcraft (launchpad) closed Classic confinement support was implemented and merged in snapcore/snapcraft#946 via commit 97af16ffe, resolving launchpad/snapcraft#1647422.
70%