← Back to issue list

tox: exclude submodules from spread-shellcheck

View original Github issue

Metadata

Project
snapcraft
Number
#4240
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged into main after passing CI and receiving approval from two reviewers. The change excludes submodules from spread-shellcheck in the tox configuration, modifying one file with five additions and three deletions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main after passing CI and receiving approval from two reviewers. The change excludes submodules from spread-shellcheck in the tox configuration, modifying one file with five additions and three deletions.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Configures tox to exclude submodules from spread-shellcheck checks. Approved by maintainer and successfully integrated after passing CI validation.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Excludes submodules from the spread-shellcheck tox environment to prevent unnecessary linting. Approved after moving out of draft.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#102 tox: pass CI environment variable starbase merged Merged after approval by two reviewers and passing CI checks. The change upstreams a modification to pass the CI environment variable to tox, adding two lines to one file.
74%
#1062 tools: import tox from starbase charmcraft merged Merged the import of the tox starbase configuration, adding eight files (+302/-0). Approved by one reviewer, the change includes unresolved linter failures that currently prevent CI integration.
71%
#1484 fix(spread): run tox in lifecycle spread test charmcraft merged Merged. Resolves #1471 by configuring tox execution within the lifecycle spread test. Approved by two reviewers with eight lines added.
71%