← Back to issue list

tools: import tox from starbase

View original Github issue

Metadata

Project
charmcraft
Number
#1062
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 4ed52927, adding Starbase's tox configuration across eight files; CI adoption was deferred because several linters failed.

Resolution: closed resolved

Reason: canonical/charmcraft#1062 was merged into the project as commit 4ed52927. The change imported the tox configuration while intentionally leaving CI integration for later remediation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This adds the tox starbase config. Note that several linters fail, so it's not appropriate to move this into CI yet.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 4ed52927, adding Starbase's tox configuration across eight files; CI adoption was deferred because several linters failed.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#1062 as commit 4ed52927, importing the tox configuration from starbase with eight added files (+302 lines).
qwen/qwen3.6-35b-a3b — — Merged the import of the tox starbase configuration, adding eight files (+302/-0). Approved by one reviewer, the change includes unresolved linter failures that currently prevent CI integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged import of tox configuration from starbase. Linter failures currently block CI integration, so the change was accepted as a standalone configuration update.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#11 tools: use the starbase tox config craft-grammar merged PR #11 by lengau merged (commit 697e4dd) adding Starbase's tox configuration: tox.ini plus four supporting config files, 183 added lines. tox.ini later dropped in #310 after rebasing on Starbase.
88%
#4046 tools: move to the starbase tox configuration snapcraft merged Merged as 618410f11, migrating tools to Starbase's tox configuration and testing Python 3.8/3.10 on Ubuntu 20.04/22.04.
83%
#1061 tools: bring tox and linting from starbase charmcraft closed Closed unmerged after years of inactivity; its tox import landed separately in canonical/charmcraft#1062 via commit 4ed52927.
82%
#433 tox: basic tox from starbase craft-parts merged Merged the Starbase-derived tox configuration in PR #433 (commit 7dbf0405), updating 24 files.
81%
#1231 tools: update tox configuration to starbase v1 charmcraft merged Merged charmcraft#1231 as commit 81ce65f2, updating the tox configuration to Starbase v1 after approval by two reviewers.
80%
#4131 tools: update tox config to latest starbase snapcraft merged Merged PR #4131 as 89fd9ecb6, updating Snapcraft's tox configuration to the latest Starbase and removing obsolete tox setup.
80%
#4 tools: Update tox and setuptools to fix breakages starbase merged Merged canonical/starbase#4 in commit 552c132, updating tox and setuptools to fix tooling breakages.
78%
#4058 tox: fix linters and makefile snapcraft merged PR #4058 by lengau merged as commit be5d4307 ("tox: fix linters and makefile"), correcting linter config in tox.ini and the Makefile after the starbase tox migration (#4046). Codecov reported no coverage change.
77%
#248 build(deps): update dependency tox-gh to v1.3.3 starbase merged Merged canonical/starbase#248 as ce9ccb9, updating tox-gh from 1.3.2 to 1.3.3 in tox.ini.
74%
#105 upstream improved tox UX starbase closed Upstream tox UX improvements were ported and merged in starbase PR #106 at commit 8b8fed8, including the CI correction noted in canonical/craft-providers#334.
71%