← Back to issue list

Login with macaroons

View original Github issue

Metadata

Project
snapcraft
Number
#428
Type
pull request
State
closed
Author
vilagithub
Labels
—
Created
Updated
Closed

Current evaluation

Unmerged. Author closed #428 in favour of consolidating the macaroon migration into snapcraft#472, which itself was closed unmerged in June 2016; macaroon login/upload/download finally shipped via merged PR #532 (f1a678a07) in snapcraft 2.10.

Resolution: closed superseded

Reason: PR author vilagithub closed #428 on 2016-04-19 stating the work "is being completed and integrated into" PR #472. #472 was later closed unmerged on 2016-06-22 after the work landed piecemeal in smaller PRs, with the macaroon login/upload/download support merged in PR #532 (commit f1a678a07, LP bug #1586910, released in snapcraft 2.10).

Evaluated by: mr-cal-bot

No scores available.

Issue body

This is the first step in the migration to use macaroons when talking to the store. I've guarded the corresponding code behind the SNAPCRAFT_WITH_MACAROONS environment variable. The config file is used for both kind of login and as far I've tested manually (for now), both can be used so the existing workflow is still usable. Feedback welcome while I proceed with register, revision, upload and publish.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Unmerged. Author closed #428 in favour of consolidating the macaroon migration into snapcraft#472, which itself was closed unmerged in June 2016; macaroon login/upload/download finally shipped via merged PR #532 (f1a678a07) in snapcraft 2.10.
stealth/space-bunny-alpha — closed superseded Closed as superseded by #472; that consolidation also closed unmerged, but macaroon login/upload/download support later merged through #532 (f1a678a07).
qwen/qwen3.6-35b-a3b — — Superseded. The macaroon login changes were merged into pull request #472 to complete the store authentication migration. The original branch was closed to consolidate the work.
qwen3.6-35b-a3b-mtp-q6 — — Superseded and integrated into pull request #472. The macaroon login feature was completed and merged as part of the broader authentication migration. Closed by the author after integration.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#472 (confidence 95%)

    Explicitly named by the author as where the macaroon migration was being completed; that PR was later closed unmerged on 2016-06-22.

  • Superseded By: canonical/snapcraft#532 (confidence 90%)

    Merged PR (commit f1a678a07) that actually delivered macaroon support to login, upload and download, shipped in snapcraft 2.10/2.10.1.

  • Related To: snapcraft (launchpad)#1586910 (confidence 80%)

    Launchpad bug LP #1586910 ('communication with servers is not authenticated with macaroons') closed by the merged #532 work.

Related issues

Issue Project State Summary Similarity
#532 Add macaroon support to login, upload and download. snapcraft merged Merged PR #532 (commit f1a678a07) added macaroon authentication to snapcraft's login, upload and download commands, closing Launchpad bug LP #1586910; shipped in snapcraft 2.10/2.10.1.
84%
#472 Macaroons snapcraft closed Large PR adding macaroon auth to login/register/upload/download plus staging-server integration tests was closed unmerged on 2016-06-22 after the work landed piecemeal in smaller PRs.
79%
#1586910 The communication with the servers is not authenticated with macaroons snapcraft (launchpad) closed Snapcraft switched store communication from OAuth to macaroon auth. Fixed by merged PR canonical/snapcraft#532 (commit f1a678a07), released in snapcraft 2.10+16.10 and verified/fixed in 2.10.1; LP bug marked verification-done.
75%
#4226 snapcraft export-login ignores expires parameter snapcraft closed Closed as stale without a Snapcraft fix. Maintainers attributed the short-lived macaroon to store-side refresh handling and later asked reporters to open a new ticket if the problem persisted.
70%