Macaroons

Metadata

Project: snapcraft
Number: #472
Type: pull request
State: closed
Author: vilagithub
Labels: —
Created: 2016-04-18 04:43 PM UTC
Updated: 2016-06-22 01:13 AM UTC
Closed: 2016-06-22 01:13 AM UTC

Current evaluation

Large PR adding macaroon auth to login/register/upload/download plus staging-server integration tests was closed unmerged on 2016-06-22 after the work landed piecemeal in smaller PRs.

Resolution: closed superseded

Reason: Maintainer sergiusens closed it saying 'we have finished the landing from multiple small pieces'. Macaroon support shipped via merged PR #532 (commit f1a678a07, 'Add macaroon support to login, upload and download'), which also covered LP #1586910.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add macaroon support to login, register and upload and download. Replace mocked tests with tests against the staging servers under snapcraft/tests/store_tests. This proved to speed up development and integration between snapcraft and the sca/sso/cpi/updown servers. Running against staging servers is opt-in and governed by setting the TEST_USER_PASSWORD. Responses are recorded and can then be used without requiring access to the servers (this address the coverage issues in the previous iterations). Package available in https://code.launchpad.net/~vila/+archive/ubuntu/ppa/+packages?field.name_filter=snapcraft&field.status_filter=published&field.series_filter= to help test/review. I'll try to keep it up to date with the content of this PR as much as possible (i.e. clicking teh recipe button ;)

Evaluation history

Date	Model	Scores	Action	Summary
2026-10-03 06:47 AM UTC	stealth/space-bunny-alpha	—	closed superseded	Large PR adding macaroon auth to login/register/upload/download plus staging-server integration tests was closed unmerged on 2016-06-22 after the work landed piecemeal in smaller PRs.
2026-09-25 03:58 AM UTC	stealth/space-bunny-alpha	—	closed superseded	Closed unmerged after macaroon support landed incrementally in smaller PRs, including #532 (f1a678a07), rather than merging this large branch.
2026-07-22 01:54 PM UTC	qwen/qwen3.6-35b-a3b	—	—	Superseded and closed. Macaroon authentication support was implemented and landed incrementally via multiple smaller pull requests instead of this single change. Original contribution acknowledged.
2026-07-20 10:58 PM UTC	qwen3.6-35b-a3b-mtp-q6	—	—	Closed as macaroon authentication support was already merged into the codebase via multiple smaller pull requests. The maintainer thanked the contributor and pointed them to the relevant merged changes.

Update history

No update history recorded yet.

Related work

Superseded By: canonical/snapcraft#532 (confidence 95%)
Merged PR containing the macaroon login/upload/download support from this branch (commit f1a678a07).
Related To: canonical/snapcraft#3562 (confidence 45%)
Later macaroonbakery interaction-error handling PR, part of the same macaroon support effort.
Related To: canonical/snapcraft#805 (confidence 40%)
Follow-up PR refreshing discharged macaroons, building on the landed macaroon support.

Related issues

Issue	Project	State	Summary	Similarity
#428 Login with macaroons	snapcraft	closed	Unmerged. Author closed #428 in favour of consolidating the macaroon migration into snapcraft#472, which itself was closed unmerged in June 2016; macaroon login/upload/download finally shipped via merged PR #532 (f1a678a07) in snapcraft 2.10.	79%
#532 Add macaroon support to login, upload and download.	snapcraft	merged	Merged PR #532 (commit f1a678a07) added macaroon authentication to snapcraft's login, upload and download commands, closing Launchpad bug LP #1586910; shipped in snapcraft 2.10/2.10.1.	72%