← Back to issue list

manifest: use `--enable-image-information` inside instances

View original Github issue

Metadata

Project
snapcraft
Number
#4330
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #4330 by mr-cal merged as commit 4f13298a1, fixing manifests not passing --enable-image-information into LXD/Multipass instances (bug dating to #3824); the flag had only been used in destructive mode.

Resolution: closed resolved

Reason: The PR itself was approved by two maintainers and merged into main as commit 4f13298a1 ('manifest: use --enable-image-information inside instances'), changing 3 files (+8/-7). It fixed a bug introduced when manifests were added to core22 in #3824, where the SNAPCRAFT_BUILD_INFO envvar was confused with the --enable-image-information flag.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- This fixes a bug that has been present since manifests were [added to core22](https://github.com/snapcore/snapcraft/pull/3824/files#diff-81bf1b8cfa88289a0432d3e12f4b4c1c104d4463a49dbc0e6c431d4e444a35cdR372-R378). The bug is that `--enable-image-information` was not passed into LXD/Multipass instances. This flag only got used when running in destructive mode. During the implementation, there was probably a typo/mix-up between the envvar `SNAPCRAFT_BUILD_INFO` and `--enable-image-information`. This bug was uncovered by #4329, which prevented the spread test from running inside a LXD container.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #4330 by mr-cal merged as commit 4f13298a1, fixing manifests not passing --enable-image-information into LXD/Multipass instances (bug dating to #3824); the flag had only been used in destructive mode.
stealth/space-bunny-alpha — closed resolved Merged #4330: manifest instance commands now pass --enable-image-information to LXD and Multipass, fixing a mix-up that limited the flag to destructive mode.
qwen/qwen3.6-35b-a3b — — Merged a fix ensuring the --enable-image-information flag is correctly passed to LXD and Multipass instances instead of only destructive mode. The three-file change passed CI, received two approvals, and achieved 100% test coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix adding the --enable-image-information flag to LXD and Multipass instances, resolving a bug where it only worked in destructive mode. The change was merged into main with 100% diff coverage and no overall coverage impact.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4329 (confidence 90%)

    Per the PR body, #4329 (merged, commit 7f8d4cff9) is what uncovered this bug by preventing the spread test from running inside a LXD container.

  • Caused By: canonical/snapcraft#3824 (confidence 80%)

    Cited as the change that added manifests to core22 and introduced the missing --enable-image-information flag inside instances.

Related issues

No related issues found above the similarity threshold.