refactor(parts): move yaml utils out of lifecycle
Metadata
Current evaluation
PR #4338 (commit fb2777fe1) merged: moved 4 snapcraft.yaml utility functions from the lifecycle module into yaml_utils, no functional changes (CRAFT-1972), done in support of #4318.
Resolution: closed resolved
Reason: The PR itself was merged into main as commit fb2777fe1 'refactor(parts): move yaml utils out of lifecycle (#4338)' with 2 approving reviewers and no functional changes, so the refactor it proposed landed as requested.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Move 4 `snapcraft.yaml` utility functions out of `lifecycle` module into the `yaml_utils` module. No functional changes.
I've been wanting to do this for some time. Working on #4318 is an excuse to get it done since it requires importing these functions.
(CRAFT-1972)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #4338 (commit fb2777fe1) merged: moved 4 snapcraft.yaml utility functions from the lifecycle module into yaml_utils, no functional changes (CRAFT-1972), done in support of #4318. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4338 moved four YAML utility functions from lifecycle to yaml_utils without functional changes; commit b2d7c7b landed in main. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after approval and passing CI. Relocated four YAML utility functions from the lifecycle module to yaml_utils. No functional changes. Prepares codebase for related work. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactoring moving four YAML utility functions from lifecycle to yaml_utils. No functional changes. Prepares codebase for related work. Codecov reported 100% diff coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4318
(confidence 85%)
Author states this refactor was done because #4318 required importing these yaml utility functions.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4342 refactor(parts): separate yaml parsing from base errors | snapcraft | merged | Merged PR #4342 as commit 33356311d, separating YAML parsing from base errors so snapcraft.yaml can be loaded for base checks; no functional changes. |