refactor(parts): separate yaml parsing from base errors
Metadata
Current evaluation
Merged PR #4342 as commit 33356311d, separating YAML parsing from base errors so snapcraft.yaml can be loaded for base checks; no functional changes.
Resolution: closed resolved
Reason: PR #4342 was merged to main as commit 33356311d. Its refactor enabled snapcraft.yaml loading and base inspection without triggering the relevant error.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
No functional changes.
Another precursory refactor for #4318 in which I need to load a `snapcraft.yaml` and check the base without raising an error.
(CRAFT-1972)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4342 as commit 33356311d, separating YAML parsing from base errors so snapcraft.yaml can be loaded for base checks; no functional changes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4342 as commit 33356311d, separating YAML parsing from base errors to enable base checks without raising errors; no functional changes. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after passing CI and receiving two approvals. The refactor separates YAML parsing from base errors to allow base validation without raising exceptions. No functional changes were made, and coverage increased by 0.01%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Refactored YAML parsing to separate it from base errors, preparing for issue #4318 to load snapcraft.yaml without raising errors. No functional changes. Diff achieved 100% test coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#4318
(confidence 100%)
PR #4342 identifies itself as a precursor needed to implement base checks for #4318.
-
Related To:
canonical/snapcraft#4343
(confidence 99%)
Merged follow-up PR #4343 added the remote-build base check and resolved #4318.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4338 refactor(parts): move yaml utils out of lifecycle | snapcraft | merged | PR #4338 (commit fb2777fe1) merged: moved 4 snapcraft.yaml utility functions from the lifecycle module into yaml_utils, no functional changes (CRAFT-1972), done in support of #4318. | |
| #1792049 Uncaught yaml.ParserError | snapcraft (launchpad) | closed | YAML parser tracebacks were fixed by merged snapcore/snapcraft PR #2263 (commit 057f66649), which catches broader YAML exceptions and reports invalid YAML. |