← Back to issue list

chore: remove unused list_registered legacy code

View original Github issue

Metadata

Project
snapcraft
Number
#4345
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged changes removing unused legacy list_registered code, eliminating final references to Price. Approved by two reviewers, passed CI, and fixes #4296. The commit modifies four files, deleting 49 lines.

Suggested action:

No scores available.

Issue body

This code has since been ported to the newer instances as a Craft CLI command "names", which uses a newer implementation that does not have any reference to price. With this we remove the last references to Price, even if unused. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- Fixes #4296

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes removing unused legacy list_registered code, eliminating final references to Price. Approved by two reviewers, passed CI, and fixes #4296. The commit modifies four files, deleting 49 lines.
qwen3.6-35b-a3b-mtp-q6 Merged into main, removing unused legacy list_registered code and final Price references now that functionality moved to the Craft CLI names command. Resolves #4296 and increases test coverage by 0.02%.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Removed unused legacy list_registered code after it was ported to the newer Craft CLI names command. Eliminates final references to Price and resolves #4296, increasing test coverage by 0.02%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5821 chore(legacy): remove script entry point snapcraft merged Merged removal of a legacy script entry point causing user confusion. Approved by two reviewers, passed CI checks, and deleted a single line in one file to clean up the codebase.
75%
#1776 chore: remove unused code charmcraft merged Merged after removing 17,571 lines of unused code across 36 files. Temporarily set to draft for additional cleanup, then approved by two reviewers and merged.
75%
#5994 chore!: remove legacy remote builder snapcraft merged Merged changes removing the legacy remote builder, resolving issue #5676. Approved by three reviewers and passing CI checks. The update deletes 3,200 lines across 30 files to clean up deprecated build infrastructure.
73%
#6079 chore: delete unused file snapcraft merged Merged a pull request removing an unused file following a migration to a pyproject-based setup. The change was approved by two reviewers, passed all CI checks, and deleted three lines from a single file.
72%
#907 chore(merge): 2.1.3 into main craft-parts merged Merged version 2.1.3 into main following approval from two reviewers and passing CI checks. The change updated seven files, adding 36 lines and removing 10.
72%
#1907 chore(cleanup): remove unused code charmcraft merged Merged cleanup removing unused code. Deleted the cmdbase module and replaced the registry module with skopeo and the docker library. Cleaned up 1857 lines across 7 files following approval from two reviewers.
72%
#6180 chore(merge): 8.14.5 into main snapcraft merged Merged version 8.14.5 into main following approval from two reviewers and successful CI checks. The update modified three files, adding 230 lines and removing 93.
71%
#392 chore: remove codeowners starbase merged Merged after approval from two reviewers and passing all CI checks. The change removes the CODEOWNERS file, deleting 9 lines from a single file as discussed in standup.
71%
#923 chore(merge): 2.1.4 into main craft-parts merged Merged release 2.1.4 back into the main branch. Approved by two reviewers with passing CI checks. The update modified 10 files, adding 49 lines and removing 16.
71%
#6035 chore!: remove deprecated commands snapcraft merged Merged after maintainer approval and a clean rebase. The changes remove deprecated commands and options, resolving issue #5674.
71%