fix: reprime for try
Metadata
Current evaluation
Superseded by #4347, which re-primed before try and was merged as commit 89fb02a19, fixing #4219.
Resolution: closed superseded
Reason: Maintainer @sergiusens closed the PR in favor of #4347. The replacement was merged and commit 89fb02a19 fixed the re-prime behavior underlying #4219.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This solves the case where prime was run before try, where a subsequent run of try would mask the contents of the existing prime directory with a newly mounted one from the host. In legacy we had the concept of `clean --unprime` to solve this.
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Fixes #4219 (in not the cleanest way)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Superseded by #4347, which re-primed before try and was merged as commit 89fb02a19, fixing #4219. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed in favor of #4347, which merged as commit 89fb02a19 and re-primes before try so host mounts cannot mask existing prime contents. | |
| stealth/space-bunny-alpha | — | closed superseded | PR #4346 (re-prime before try) was closed unmerged in favour of #4347, which merged as commit 89fb02a19 into hotfix/7.5 and fixed #4219 by re-priming before mounting. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed in favor of canonical/snapcraft#4347, which merged as 89fb02a19 and fixed #4219 by re-priming before try to prevent host mounts from masking prime contents. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed in favor of #4347, which revised reprime handling for try and merged into hotfix/7.5 to fix #4219 without masking an existing prime directory. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as superseded by #4347, which merged into hotfix/7.5 and fixed #4219 by re-priming before try to avoid masking the existing prime directory. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #4347. The pull request addressed a bug where running try after prime masked existing prime directory contents. The maintainer closed it to consolidate the fix into another pull request. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed and superseded by PR #4347. The original fix addressed an issue where running try after prime masked existing directory contents, but the maintainer closed it to pursue an alternative solution in the referenced PR. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#4347
(confidence 100%)
The maintainer explicitly closed #4346 in favor of #4347.
-
Likely Fixed By:
canonical/snapcraft#4219
(confidence 100%)
The linked issue was fixed by the re-prime change merged in #4347.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4347 fix: reprime for try | snapcraft | merged | Merged PR #4347 (commit 89fb02a19) re-primes before try, preventing a host mount from masking existing prime contents and fixing #4219. |