← Back to issue list

fix: reprime for try

View original Github issue

Metadata

Project
snapcraft
Number
#4347
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4347 (commit 89fb02a19) re-primes before try, preventing a host mount from masking existing prime contents and fixing #4219.

Resolution: closed resolved

Reason: PR #4347 was approved and merged as commit 89fb02a19. It fixes #4219 by re-priming when snapcraft try finds an existing prime directory.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This solves the case where prime was run before try, where a subsequent run of try would mask the contents of the existing prime directory with a newly mounted one from the host. In legacy we had the concept of `clean --unprime` to solve this. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- Fixes #4219

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4347 (commit 89fb02a19) re-primes before try, preventing a host mount from masking existing prime contents and fixing #4219.
stealth/space-bunny-alpha — closed resolved Merged PR #4347 as commit 89fb02a19, making try re-prime over an existing prime directory so a host mount no longer masks its contents; fixes #4219.
stealth/space-bunny-alpha — closed resolved Merged #4347 (526fad1) into hotfix/7.5, adding re-priming for try so a host mount cannot mask existing prime contents, fixing #4219.
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.5 as commit 89fb02a19, fixing #4219: try now re-primes so its host mount no longer masks an existing prime directory.
qwen/qwen3.6-35b-a3b — — Merged into hotfix/7.5 to fix #4219. Prevents try from masking existing prime directory contents with a newly mounted host directory. Restores legacy unprime behavior. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for reprime during try operations to prevent masking existing prime directory contents. Resolves #4219 by restoring legacy unprime behavior. Integrated into hotfix/7.5.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4219 (confidence 100%)

    This was the LXD try issue fixed by the merged PR.

Related issues

Issue Project State Summary Similarity
#4346 fix: reprime for try snapcraft closed Superseded by #4347, which re-primed before try and was merged as commit 89fb02a19, fixing #4219.
85%
#540 Reprime detection craft-parts open Maintainer request for craft-parts to detect a rerouted prime directory and unprime before re-priming; still open, while snapcraft#4219 received a separate try-specific workaround.
70%