← Back to issue list

Add regression test for incorrect project variable expansion

View original Github issue

Metadata

Project
snapcraft
Number
#4363
Type
issue
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Closed as resolved via craft-parts #554 (438fa857), which added ordering comments and a regression test for premature project-variable expansion.

Resolution: closed resolved

Reason: The linked defect was fixed in canonical/craft-parts#554 at commit 438fa857 by adding dictionary-ordering comments and a regression test. Snapcraft #4363 explicitly identified canonical/craft-parts#541 as the same variable-expansion bug.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description This is the same as https://github.com/canonical/craft-parts/issues/541, except for core20 snaps. The ordering of the [dictionary](https://github.com/snapcore/snapcraft/blob/c8e9b2e423cb0702d240814b21224843541c9d2b/snapcraft_legacy/internal/pluginhandler/_part_environment.py#L74) happens to be correct but there are no comments or regression tests. ### To Reproduce n/a ### Environment n/a ### snapcraft.yaml ```shell n/a ``` ### Relevant log output ```shell n/a ``` ### Additional context _No response_

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Closed as resolved via craft-parts #554 (438fa857), which added ordering comments and a regression test for premature project-variable expansion.
stealth/space-bunny-alpha — closed resolved Resolved core20’s analogous variable-expansion coverage by referencing craft-parts#541, which added dictionary-ordering comments and a regression test.
qwen/qwen3.6-35b-a3b — — Closed without action. The request for a core20 regression test was abandoned due to missing reproduction steps, zero comments, and no follow-up. Likely superseded by the referenced craft-parts issue.
qwen/qwen3.6-35b-a3b — — Closed without implementation or resolution. The request for a regression test was abandoned due to zero comments and inactivity.
qwen/qwen3.6-35b-a3b — — Requesting a regression test for project variable expansion, the issue was closed without comments or linked pull requests, indicating the task was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation or merge. The requested regression test for core20 project variable expansion was not added, likely abandoned or superseded.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#541 (confidence 100%)

    Explicitly cited as the same premature variable-expansion defect.

  • Likely Fixed By: canonical/craft-parts#554 (confidence 95%)

    Merged fix 438fa857 added ordering comments and regression coverage.

Related issues

No related issues found above the similarity threshold.