refactor(remote-build): reorganize functions
Metadata
Current evaluation
Merged #4384 via commit 23e2601c9, reorganizing remote-build functions in preparation for #4322; follow-up #4385 added build-ID generation.
Resolution: closed resolved
Reason: PR #4384 was approved and merged as commit 23e2601c9. The preparatory refactor enabled follow-up PR #4385, merged as 5fc76d839, to implement build-ID generation for #4322.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
2 separate commits - do not squash
Refactor and cleanup in preparation for #4322. Now there is a location to add code for #4322.
(CRAFT-1977)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4384 via commit 23e2601c9, reorganizing remote-build functions in preparation for #4322; follow-up #4385 added build-ID generation. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4384 (23e2601c9), a two-commit refactor reorganizing remote-build functions in preparation for #4322, with 100% diff coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a two-commit refactor reorganizing remote-build functions to prepare for issue #4322. Approved by two reviewers, passed CI checks, and modified two files with a net reduction of 40 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring that reorganizes remote-build functions to prepare for issue #4322. The change maintains 100% diff coverage, with the author dismissing a minor Codecov reporting discrepancy. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#4385
(confidence 99%)
Merged follow-up that added build-ID generation and resolved #4322 after this preparatory refactor.
-
Related To:
snapcore/snapcraft#4322
(confidence 98%)
Issue targeted by the reorganized remote-build code and implemented through follow-up PR #4385.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4324 remote-build: new command logic | snapcraft | closed | Remote-build logic was replaced by merged PR #4395 (commit 2e0647594), adding isolated per-build cache worktrees, cleanup, and generated build IDs. | |
| #4660 refactor(test): versioned remote-build tests | snapcraft | merged | Merged PR #4660 (commit 2423be37e), refactoring versioned remote-build tests without logic changes. | |
| #4395 feat(remote-build): new command logic | snapcraft | merged | Merged as commit 2e0647594; adds RemoteBuild class and new remote-build command orchestration, per-build project cache in the local cache dir with post-build cleanup, plus typing/lint updates (CRAFT-1979). Fixes #4324. | |
| #4385 feat(remote-build): get build id | snapcraft | merged | Merged PR #4385 in commit 5fc76d839, adding remote-build build-ID generation and command-line build-ID support; fixes #4322. | |
| #2774 remote-build: architecture handling | snapcraft | merged | Merged PR #2774 via commit 8300281d6, cleaning up and fixing remote-build architecture handling. Missing CLI unit tests were acknowledged as follow-up work. | |
| #4432 fix(remote-build): improve logging and catch exceptions | snapcraft | merged | Merged #4432, adding RemoteBuildError handling and improving remote-build logging for #4399; commits fb9a01d0b and 663dcdfab. |