← Back to issue list

Various Fixes for Gnome Extension

View original Github issue

Metadata

Project
snapcraft
Number
#4391
Type
pull request
State
closed
Author
soumyaDghosh
Labels
Created
Updated
Closed

Current evaluation

Closed and superseded. Reviewers requested splitting the changes and adding missing unit tests. The author abandoned this PR and recreated it with updated changes.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- ## Changes: - The gnome-sdk has webkit2gtk-4.1 files, but it also needs a layout just like webkit2gkt-4.0. - Changed the `SNAPCRAFT` in the layouts to `CRAFT` - Updated description[Gnome SDK now has Gnome-45 libraries also]

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed and superseded. Reviewers requested splitting the changes and adding missing unit tests. The author abandoned this PR and recreated it with updated changes.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. Maintainers requested unit tests for the code changes and suggested splitting the PR. The author closed it to recreate separate, test-compliant pull requests.
qwen3.6-35b-a3b-mtp-q6 Closed without merging due to missing unit tests. Maintainers advised splitting the changes or trimming the scope. The author abandoned the PR to recreate it with updated tests and modifications.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2794 Add gnome 3 34 extension snapcraft closed Abandoned in favor of a new PR. After review and temporary store testing, the author restructured commits, separated formatting changes, and planned further validation before ultimately closing this branch to restart the contribution elsewhere.
76%
#4798 extension: fix issues and depreciated vars in gnome extension snapcraft merged Merged changes fixing issues and deprecated variables in the GNOME extension. Approved by two reviewers, passed all CI checks, and modified two files with six additions and six deletions.
73%
#3759 extensions: add core22 gnome (rebased) snapcraft closed Superseded by PR #3760. The author closed this request to submit a rebased version with unit tests, as recommended by the maintainer.
72%