Various Fixes for Gnome Extension
Metadata
Current evaluation
Closed unmerged after reviewers requested separate text/layout changes and unit tests; the author said on 2023-11-17 that the work would be recreated with added changes.
Resolution: closed superseded
Reason: Reviewers asked the author to split or trim the oversized change because related unit tests were missing. The author then stated that the work was being recreated, although no replacement PR is identified in the available history.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
## Changes:
- The gnome-sdk has webkit2gtk-4.1 files, but it also needs a layout just like webkit2gkt-4.0.
- Changed the `SNAPCRAFT` in the layouts to `CRAFT`
- Updated description[Gnome SDK now has Gnome-45 libraries also]
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after reviewers requested separate text/layout changes and unit tests; the author said on 2023-11-17 that the work would be recreated with added changes. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and superseded after reviewers requested separate text/layout changes and missing unit tests; the author said on 2023-11-17 that they were recreating the PR. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed and superseded. Reviewers requested splitting the changes and adding missing unit tests. The author abandoned this PR and recreated it with updated changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. Maintainers requested unit tests for the code changes and suggested splitting the PR. The author closed it to recreate separate, test-compliant pull requests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2794 Add gnome 3 34 extension | snapcraft | closed | Closed unmerged in favor of #2956, which added the GNOME 3.34 extension and was merged as commit 1a411b0bb. |