← Back to issue list

Add gnome 3 34 extension

View original Github issue

Metadata

Project
snapcraft
Number
#2794
Type
pull request
State
closed
Author
hellsworth
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged in favor of #2956, which added the GNOME 3.34 extension and was merged as commit 1a411b0bb.

Resolution: closed superseded

Reason: The author closed #2794 in favor of a replacement PR. canonical/snapcraft#2956 subsequently merged the GNOME 3.34 extension in commit 1a411b0bb.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - would reformat snapcraft/plugins/dotnet.py. I didn't make this change since I know the CI doesn't use the latest version of black. - [x] Have you successfully run `./runtests.sh tests/unit`? - yes, there are still 5 failing tests I'll need to look at -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #2956, which added the GNOME 3.34 extension and was merged as commit 1a411b0bb.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of canonical/snapcraft#2956, which added GNOME 3.34 extension support and was merged as commit 1a411b0bb.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of snapcraft#2956, which added the GNOME 3.34 extension and was merged as commit 1a411b0bb.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of canonical/snapcraft#2956, which added GNOME 3.34 extension support and was merged as commit 1a411b0bb.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of a new PR after review and temporary store testing; no code from this PR was merged.
qwen/qwen3.6-35b-a3b — — Abandoned in favor of a new PR. After review and temporary store testing, the author restructured commits, separated formatting changes, and planned further validation before ultimately closing this branch to restart the contribution elsewhere.
qwen3.6-35b-a3b-mtp-q6 — — Closed in favor of a new PR. The author paused merging to integrate gtkmm into the build snap and validate the extension with real-world applications before resubmitting.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#2956 (confidence 100%)

    The replacement PR added the requested extension and was merged.

Related issues

Issue Project State Summary Similarity
#2956 Add gnome 3 34 extension snapcraft merged Merged as #2956 (commit 1a411b0bb), adding the gnome-3-34 extension for core18 and replacing #2794; later follow-ups added gcc build-packages (#2995) and XDG_DATA_DIRS/PYTHONPATH fixes (#3340, #3426).
83%
#3427 extensions: make GNOME 3.38 stable snapcraft merged Merged PR #3427, promoting the GNOME 3.38 extension to stable in commit a99bc7e4e.
76%
#3407 Add new gnome-3-38 extension which uses gnome-3-38-2004 and core20 snapcraft merged Merged PR #3407 (974afae60), introducing the gnome-3-38 extension built on gnome-3-38-2004 and core20.
76%
#1853040 gnome-3-34 extension - build-environment needs to merge snapcraft (launchpad) closed Superseded by canonical/snapcraft#2956 (commit 1a411b0bb), which added GNOME 3.34 extension support; proposed fix snapcore/snapcraft#2794 was closed unmerged.
75%
#2398 gnome extension snapcraft closed Closed unmerged after review; the GNOME extension was reworked and merged in snapcore/snapcraft#2655 via commit b0c4319e5.
75%
#4391 Various Fixes for Gnome Extension snapcraft closed Closed unmerged after reviewers requested separate text/layout changes and unit tests; the author said on 2023-11-17 that the work would be recreated with added changes.
70%