← Back to issue list

chore: ignore types

View original Github issue

Metadata

Project
snapcraft
Number
#4406
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4406 as feb701d30, suppressing pkg_resources type errors from pyright 1.1.332 and unblocking PEP 518 support in #4087.

Resolution: closed resolved

Reason: PR #4406 was merged as commit feb701d30. It added the temporary type ignores needed to clear Pyright errors and proceed with #4087.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- Fix for errors in pyright 1.1.332. Unblocks #4087

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4406 as feb701d30, suppressing pkg_resources type errors from pyright 1.1.332 and unblocking PEP 518 support in #4087.
stealth/space-bunny-alpha — closed resolved Merged PR #4406 as commit feb701d30, adding pyright ignore comments for pkg_resources stubs to fix new errors in pyright 1.1.332 and unblock PEP 518 build support in #4087; follow-up #4407 tracks pkg_resources removal.
stealth/space-bunny-alpha — closed resolved Merged PR #4406 as commit feb701d30, suppressing pkg_resources type errors from pyright 1.1.332 and unblocking Python v2 PEP 518 support in #4087. Follow-up #4407 tracks pkg_resources removal.
qwen/qwen3.6-35b-a3b — — Merged to resolve pyright 1.1.332 type errors by ignoring specific types, unblocking issue #4087. The change updates two files. A follow-up task to remove pkg_resources was created as issue #4407.
qwen3.6-35b-a3b-mtp-q6 — — Merged to fix pyright 1.1.332 type errors and unblock #4087. Approved by maintainer despite a 0.01% coverage drop. Follow-up issue #4407 tracks future pkg_resources removal.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4087 (confidence 100%)

    PEP 518 Python v2 plugin support was explicitly unblocked by this PR.

  • Related To: snapcraft#4407 (confidence 100%)

    Follow-up work to remove pkg_resources; later resolved by #4490 in commit 73afa9dc6.

Related issues

Issue Project State Summary Similarity
#206 chore(deps): update dependency types/pyright to v1.1.359 starbase merged Merged PR #206 updated types/pyright from 1.1.358 to 1.1.359 via commit 06f6913.
77%
#196 chore(deps): update dependency types/pyright to v1.1.356 starbase merged Merged PR #196 updated types/pyright from 1.1.355 to 1.1.356 via commit 5d10b2a.
77%
#251 chore(deps): update dependency types/pyright to v1.1.359 craft-cli merged Merged PR #251 updated types/pyright from 1.1.358 to 1.1.359 in commit ad50596.
77%
#550 chore(deps): update dependency types/pyright to v1.1.358 craft-providers merged Renovate updated types/pyright from v1.1.357 to v1.1.358; PR #550 was merged in commit 689cc8d.
77%
#10 chore(deps): update dependency types/pyright to v1.1.368 craft-platforms merged Merged PR #10 updated types/pyright from 1.1.367 to 1.1.368; the dependency bump landed in commit c9e48a8.
76%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged PR #181 merged into main as commit d34fdd6 (Sep 2023): added typing stub dependencies and fixed the resulting Pyright errors, a 1-file, +6/-1 lint/tooling change.
76%
#228 chore(deps): update dependency types/pyright to v1.1.374 - autoclosed starbase closed Renovate PR #228 was autoclosed unmerged; merged PR #234 superseded it by bumping Pyright from 1.1.372 to 1.1.375 in commit d88dde5.
76%
#24 chore(deps): update dependency types/pyright to v1.1.374 craft-platforms merged Merged PR #24 as commit ef30d00, updating types/pyright from v1.1.373 to v1.1.374.
76%
#155 chore(deps): update dependency types/pyright to v1.1.338 starbase merged Merged PR #155 updated types/pyright from 1.1.337 to 1.1.338; Codecov reported 100% coverage.
76%
#222 chore(deps): update dependency types/pyright to v1.1.371 starbase merged Merged #222 via commit 3616458, updating types/pyright from v1.1.366 to v1.1.371.
76%