chore: ignore types
Metadata
Current evaluation
Merged to resolve pyright 1.1.332 type errors by ignoring specific types, unblocking issue #4087. The change updates two files. A follow-up task to remove pkg_resources was created as issue #4407.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Fix for errors in pyright 1.1.332. Unblocks #4087
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to resolve pyright 1.1.332 type errors by ignoring specific types, unblocking issue #4087. The change updates two files. A follow-up task to remove pkg_resources was created as issue #4407. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to fix pyright 1.1.332 type errors and unblock #4087. Approved by maintainer despite a 0.01% coverage drop. Follow-up issue #4407 tracks future pkg_resources removal. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve pyright 1.1.332 type errors and unblock issue #4087. Maintainer approved the changes, noting a follow-up task to remove pkg_resources tracked in issue #4407. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #181 chore(lint): add new typing dependencies and fix pyright issues | craft-cli | merged | Merged into main following approval. The update adds typing dependencies and resolves pyright type errors across a single file. All CI checks passed, and code coverage remained stable during integration. | |
| #251 chore(deps): update dependency types/pyright to v1.1.359 | craft-cli | merged | Merged automated dependency update for types/pyright from v1.1.358 to v1.1.359. Approved by two reviewers, passed CI checks, and automatically merged via Renovate bot configuration. Single file change. | |
| #189 chore(deps): update dependency types/pyright to v1.1.351 | starbase | merged | Merged automated dependency update for types/pyright from v1.1.350 to v1.1.351. Approved by a reviewer, passed CI checks, and merged via Renovate bot automerge. | |
| #216 chore(deps): update dependency types/pyright to v1.1.364 | starbase | merged | Merged automated dependency update upgrading types/pyright from v1.1.363 to v1.1.364. Approved by a reviewer, passed CI checks, and auto-merged by Renovate bot, modifying a single file. | |
| #198 chore(deps): update dependency types/pyright to v1.1.357 | starbase | merged | Merged automated dependency update for types/pyright from v1.1.356 to v1.1.357. The change passed CI, received reviewer approval, and was automatically merged into the main branch via Renovate bot. | |
| #314 chore(deps): update dependency types/pyright to v1.1.359 | craft-application | merged | Merged automated dependency update for types/pyright from v1.1.358 to v1.1.359. The change received two approvals, passed all CI checks, and was successfully merged into the main branch. | |
| #202 chore(deps): update dependency types/pyright to v1.1.358 | starbase | merged | Merged automated dependency update for types/pyright from v1.1.357 to v1.1.358. Approved by a reviewer, passed all CI checks, and auto-merged via Renovate bot configuration. | |
| #135 chore(deps): update dependency types/pyright to v1.1.339 | craft-store | merged | Merged automated dependency update for types/pyright from v1.1.338 to v1.1.339. Approved by two reviewers, passed CI, and auto-merged via Renovate bot configuration. | |
| #220 chore(deps): update dependency types/pyright to v1.1.366 | starbase | merged | Merged automated dependency update for types/pyright from v1.1.365 to v1.1.366. Generated by Renovate, approved by a reviewer, passed CI checks, and automatically merged into the main branch. | |
| #206 chore(deps): update dependency types/pyright to v1.1.359 | starbase | merged | Merged automated dependency update upgrading types/pyright from v1.1.358 to v1.1.359. Approved by a reviewer, passed CI checks, and auto-merged into the main branch. |