← Back to issue list

chore(lint): add new typing dependencies and fix pyright issues

View original Github issue

Metadata

Project
craft-cli
Number
#181
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged into main following approval. The update adds typing dependencies and resolves pyright type errors across a single file. All CI checks passed, and code coverage remained stable during integration.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main following approval. The update adds typing dependencies and resolves pyright type errors across a single file. All CI checks passed, and code coverage remained stable during integration.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Added new typing dependencies and resolved pyright type checking issues. Code coverage remains unchanged at 94.62%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#117 chore: fix pyright config craft-store merged Merged after two reviewers approved and CI checks passed. The pull request updates the pyright configuration across two files, adding 24 lines and removing 16 to resolve type-checking setup issues.
82%
#206 chore(deps): update dependency types/pyright to v1.1.359 starbase merged Merged automated dependency update upgrading types/pyright from v1.1.358 to v1.1.359. Approved by a reviewer, passed CI checks, and auto-merged into the main branch.
82%
#314 chore(deps): update dependency types/pyright to v1.1.359 craft-application merged Merged automated dependency update for types/pyright from v1.1.358 to v1.1.359. The change received two approvals, passed all CI checks, and was successfully merged into the main branch.
82%
#251 chore(deps): update dependency types/pyright to v1.1.359 craft-cli merged Merged automated dependency update for types/pyright from v1.1.358 to v1.1.359. Approved by two reviewers, passed CI checks, and automatically merged via Renovate bot configuration. Single file change.
82%
#198 chore(deps): update dependency types/pyright to v1.1.357 starbase merged Merged automated dependency update for types/pyright from v1.1.356 to v1.1.357. The change passed CI, received reviewer approval, and was automatically merged into the main branch via Renovate bot.
81%
#155 chore(deps): update dependency types/pyright to v1.1.338 starbase merged Merged automated dependency update for types/pyright from v1.1.337 to v1.1.338. Approved by a reviewer, passed all CI checks, and maintained 100% test coverage. Changes applied via Renovate bot.
81%
#189 chore(deps): update dependency types/pyright to v1.1.351 starbase merged Merged automated dependency update for types/pyright from v1.1.350 to v1.1.351. Approved by a reviewer, passed CI checks, and merged via Renovate bot automerge.
81%
#225 chore(deps): update dependency types/pyright to v1.1.349 craft-cli merged Merged automated dependency update for types/pyright from v1.1.348 to v1.1.349. Approved by two reviewers, passed CI and coverage checks, and automatically merged per weekend schedule.
81%
#178 chore(deps): update dependency types/pyright to v1.1.327 craft-cli merged Merged automated dependency update for types/pyright from v1.1.326 to v1.1.327. Approved by reviewer, passed CI checks, and merged via Renovate automerge. Coverage increased by 1.63%.
81%
#135 chore(deps): update dependency types/pyright to v1.1.339 craft-store merged Merged automated dependency update for types/pyright from v1.1.338 to v1.1.339. Approved by two reviewers, passed CI, and auto-merged via Renovate bot configuration.
81%