chore(lint): add new typing dependencies and fix pyright issues
Metadata
Current evaluation
PR #181 merged into main as commit d34fdd6 (Sep 2023): added typing stub dependencies and fixed the resulting Pyright errors, a 1-file, +6/-1 lint/tooling change.
Resolution: closed resolved
Reason: The pull request itself was merged by maintainer lengau after approval, landing on main as commit d34fdd6 "chore(lint): add new typing dependencies and fix pyright issues (#181)". The only comment was an automated Codecov note confirming no coverage change.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #181 merged into main as commit d34fdd6 (Sep 2023): added typing stub dependencies and fixed the resulting Pyright errors, a 1-file, +6/-1 lint/tooling change. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main in PR #181 as commit d34fdd6, adding typing dependencies and fixing the associated Pyright issues. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main following approval. The update adds typing dependencies and resolves pyright type errors across a single file. All CI checks passed, and code coverage remained stable during integration. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-cli#237
(confidence 62%)
Later commit 675d42a "style: fix pyright config (#237)" continues the same Pyright lint configuration cleanup.
-
Related To:
canonical/craft-cli#479
(confidence 55%)
Commit 0e49c01 "style: drop mypy, pyright (#479)" eventually removed the Pyright tooling this PR configured.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #189 chore(deps): update dependency types/pyright to v1.1.351 | starbase | merged | Renovate dependency bump PR merged into main: types/pyright 1.1.350 -> 1.1.351, landing as commit 826a08e (approved, +1/-1 line in pyproject.toml). | |
| #228 chore(deps): update dependency types/pyright to v1.1.374 - autoclosed | starbase | closed | Renovate PR #228 was autoclosed unmerged; merged PR #234 superseded it by bumping Pyright from 1.1.372 to 1.1.375 in commit d88dde5. | |
| #314 chore(deps): update dependency types/pyright to v1.1.359 | craft-application | merged | Renovate bumped types/pyright from 1.1.358 to 1.1.359 in dev dependencies; approved (2 reviewers) and merged to main as commit 3adbe37d (April 2024). | |
| #24 chore(deps): update dependency types/pyright to v1.1.374 | craft-platforms | merged | Merged PR #24 as commit ef30d00, updating types/pyright from v1.1.373 to v1.1.374. | |
| #196 chore(deps): update dependency types/pyright to v1.1.356 | starbase | merged | Merged PR #196 updated types/pyright from 1.1.355 to 1.1.356 via commit 5d10b2a. | |
| #206 chore(deps): update dependency types/pyright to v1.1.359 | starbase | merged | Merged PR #206 updated types/pyright from 1.1.358 to 1.1.359 via commit 06f6913. | |
| #155 chore(deps): update dependency types/pyright to v1.1.338 | starbase | merged | Merged PR #155 updated types/pyright from 1.1.337 to 1.1.338; Codecov reported 100% coverage. | |
| #10 chore(deps): update dependency types/pyright to v1.1.368 | craft-platforms | merged | Merged PR #10 updated types/pyright from 1.1.367 to 1.1.368; the dependency bump landed in commit c9e48a8. | |
| #22 chore(deps): update dependency types/pyright to v1.1.373 | craft-platforms | merged | Renovate PR #22 bumped types/pyright from 1.1.372 to 1.1.373 in pyproject.toml (+1/-1) and was auto-merged via Renovate automerge, landing as commit d26cc2f. | |
| #251 chore(deps): update dependency types/pyright to v1.1.359 | craft-cli | merged | Merged PR #251 updated types/pyright from 1.1.358 to 1.1.359 in commit ad50596. |