← Back to issue list

ci: pin pyright

View original Github issue

Metadata

Project
snapcraft
Number
#4420
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged a one-line change pinning pyright in CI requirements for hotfix branches. Approved by one reviewer, passed all CI checks, and integrated successfully despite unrelated upstream test failures.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- On `hotfix` branches, `pyright` should be pinned like all other requirements.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a one-line change pinning pyright in CI requirements for hotfix branches. Approved by one reviewer, passed all CI checks, and integrated successfully despite unrelated upstream test failures.
qwen3.6-35b-a3b-mtp-q6 Merged to pin pyright in CI for hotfix branches. The maintainer approved the change after confirming unrelated test failures stemmed from upstream Flutter issues and store connectivity problems, not the PR modifications.
qwen3.6-35b-a3b-mtp-q6 Merged to pin pyright on hotfix branches, matching other requirements. Unrelated test failures were noted but did not prevent the merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4512 ci: pin pyright to 1.1.344 snapcraft merged Merged a change pinning pyright to version 1.1.344 to prevent CI failures from breaking patch releases. Approved by two reviewers, passed all checks, and updated only the CI configuration file.
87%
#237 style: fix pyright config craft-cli merged Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.
73%
#39 ci: unpin dependencies craft-cli merged Merged to unpin CI dependencies. Approved by one reviewer with no unresolved comments. Modified six files, removing 124 lines and adding eight, streamlining the continuous integration setup.
72%
#3261 requirements: pin setuptools devel requirement snapcraft merged Merged changes pinning the setuptools development requirement. Approved by one reviewer, passed CI checks, and modified one file with a single line addition.
72%
#78 fix(ci): force push to the correct launchpad repo fetch-service merged Merged a one-line CI fix correcting a force push to the proper Launchpad repository. Approved by two reviewers with zero unresolved comments and no failing checks.
70%
#4233 type: workaround for pyright bug snapcraft merged Merged a two-file change (+4/-3 lines) implementing a workaround for pyright bug #5394. Approved by one reviewer, passed CI checks, and successfully integrated into the codebase.
70%
#18 ci: ensure tests succeed in CI craft-application merged Merged updates to CI configuration ensuring tests pass successfully. Approved by one reviewer, modifying five files with 23 additions and 13 deletions.
70%
#291 ci: fix failing tests imagecraft merged Merged after passing all CI checks and receiving two approvals. Fixed failing tests by adding an expected argument, pinning pygit2 below 1.15.0, and updating the Rust toolchain to 1.89 for maturin 1.12 compatibility.
70%
#565 ci: pin pylint version craft-parts merged Merged to pin the pylint version in CI configuration. Approved by two reviewers, the change provides immediate stability as a temporary measure before the planned migration to ruff.
70%