← Back to issue list

type: fix pyright possibly-unbound error

View original Github issue

Metadata

Project
rockcraft
Number
#342
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929.

Resolution: closed resolved

Reason: The PR was approved and merged after review. Repository history records the fix as commit 06629929.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#342 as commit 06629929, correcting a one-file Pyright possibly-unbound error.
qwen/qwen3.6-35b-a3b — — Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for a pyright possibly-unbound type error. Authored by maintainer lengau, the pull request was successfully integrated into the codebase without additional comments or revisions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#65 Fixed new pyright issues. craft-cli merged Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479).
79%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated.
77%
#94 Fixed new pyright issues. craft-providers merged PR #94 was merged, fixing new Pyright errors and making Makefile test targets explicit; merged in 432a4f2 with implementation commit 101df6c.
76%
#1703 build: update pyright to 1.1.366 charmcraft merged Merged PR #1703 upgraded Pyright to 1.1.366 in two build files via commit d189a48e.
76%
#237 style: fix pyright config craft-cli merged Merged #237 (commit 675d42a), updating two Pyright ignore patterns so they apply recursively.
75%
#1525 build: enable pyright charmcraft merged Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption.
75%
#158 chore: fix pyright error craft-archives merged Merged PR #158 as commit fc48bed, fixing a Pyright error with a one-line deletion despite a failing minimum-dependencies job.
74%
#639 style: update pyright craft-parts merged Merged #639 in commit 162a3522, updating Pyright and including codespell autofixes across four files.
74%
#613 build(deps): update pyright to 1.1.373 craft-providers merged Merged PR #613 updated pyright to 1.1.373 in commit 0f8df4f.
74%
#4233 type: workaround for pyright bug snapcraft merged Merged as f5b2f2e0f, adding a two-file typing workaround for microsoft/pyright#5394 after maintainer approval.
73%